Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove Default, HasCompact, and TypeInfo trait bounds on AssetId #12740

Merged
merged 17 commits into from
Nov 28, 2022
Merged

Remove Default, HasCompact, and TypeInfo trait bounds on AssetId #12740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c33fb78
Remove Default, HasCompact, and TypeInfo trait bounds on AssetId
joepetrowski Nov 19, 2022
825fe32
don't use default in benchmarking
joepetrowski Nov 19, 2022
6a7e4dc
add helper trait
joepetrowski Nov 19, 2022
149be83
add helper to assets tx payment test
joepetrowski Nov 19, 2022
0afa38c
docs fixes
joepetrowski Nov 20, 2022
6b3fd75
i'm confused
joepetrowski Nov 20, 2022
b557518
aha, cargo
joepetrowski Nov 20, 2022
608f0e6
Merge remote-tracking branch 'origin/master' into joe-assetid-bounds
Nov 21, 2022
2b255d7
move affected dispatchable calls into new indices
joepetrowski Nov 22, 2022
da7251c
Helper -> BenchmarkHelper
joepetrowski Nov 22, 2022
bac8e73
benchmark use of helper
joepetrowski Nov 22, 2022
e0d5929
actually, don't break every call interface
joepetrowski Nov 24, 2022
4d1d32c
use into on AssetIdParameter
joepetrowski Nov 24, 2022
803ecfe
Merge remote-tracking branch 'origin' into joe-assetid-bounds
joepetrowski Nov 24, 2022
46dfc28
Remove From from AssetIdParameter and use it in BenchmarkHelper
joepetrowski Nov 28, 2022
b6e7af5
Merge remote-tracking branch 'origin' into joe-assetid-bounds
joepetrowski Nov 28, 2022
e3337bc
include from
joepetrowski Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions bin/node/runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,6 +1440,7 @@ impl pallet_assets::Config for Runtime {
type RuntimeEvent = RuntimeEvent;
type Balance = u128;
type AssetId = u32;
type AssetIdParameter = codec::Compact<u32>;
type Currency = Balances;
type CreateOrigin = AsEnsureOriginWithArg<EnsureSigned<AccountId>>;
type ForceOrigin = EnsureRoot<AccountId>;
Expand All @@ -1453,6 +1454,8 @@ impl pallet_assets::Config for Runtime {
type Extra = ();
type WeightInfo = pallet_assets::weights::SubstrateWeight<Runtime>;
type RemoveItemsLimit = ConstU32<1000>;
#[cfg(feature = "runtime-benchmarks")]
type BenchmarkHelper = ();
}

parameter_types! {
Expand Down
Loading