This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature] P2 Staking Tracker #12744
[Feature] P2 Staking Tracker #12744
Changes from all commits
91dd322
e8127c7
c809c57
99bd9d7
0d4a022
c5bb19c
5549a78
1666bdc
e7cfb35
54b2e33
da8f780
c89d8ec
7fcafe0
6689460
9f3e436
bed5ad4
84ec3d4
f65e5bd
c11877f
345585e
09550de
69b27c5
b9b4978
1cd145a
3297703
c618967
6b33afc
bd18275
9c70db7
9b3fdf9
4a126cc
70fceb5
9a90e4b
85529a3
08118a4
ace54bb
ea35228
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the names in two lines are not consistent -- either both
somethingTracker
or neither.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea here is that the TargetList is not used in Staking yet, so we can start tracking it in staking-tracker and then passing it to Staking without any migrations.
Since VoterList already exists - I had to add a suffix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these two instances are only going to be used by the
stake-tracker
, they could be better named things likeStakeTrackerVoter
andStakeTrackerTargets
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VoterList is used in the original Staking. TargetList, once tested, will be passed to Staking as well. It kind of felt strange to be renaming this back and forth, as those lists shouldn't care who tracks them and neither should the Staking pallet.
Unfortunately I had to add an ugly VoterListTracker bags-list, but that will be dropped as soon as we have concluded that the original VoterList tracked by Staking and the new one are one and the same.
Let me know if this makes sense.