This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Staking: store minimum active stake on-chain #12889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing the `min-active-bond` onchain helps the UIs with minimal on-chain costs. Closes #12746
gpestana
added
A0-please_review
gpestana
commented
Dec 9, 2022
kianenigma
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
What you are doing is technically the MinimumActiveVoter, as per https://polkadot.network/blog/staking-update-february-2022/#staking-terminology, agree? if so, i think some names can reflect this a bit better.
Coding is the easy part.
- @rossbulat you can now use this easily in the dashboard.
- @DrW3RK might find this useful
- Please make sure this is mentioned in the next staking newsletter.
- ...
kianenigma
reviewed
Dec 12, 2022
kianenigma
reviewed
Dec 12, 2022
kianenigma
reviewed
Dec 12, 2022
kianenigma
reviewed
Dec 12, 2022
kianenigma
added
B7-runtimenoteworthy
C1-low
I agree, I'm not fully happy with the naming |
Ank4n
reviewed
Dec 13, 2022
Ank4n
approved these changes
Dec 13, 2022
|
bot merge |
paritytech-processbot
bot
deleted the
gpestana/12746-onchain-min-active-bond
branch
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* Staking: store last min-active-bond on-chain Storing the `min-active-bond` onchain helps the UIs with minimal on-chain costs. Closes paritytech#12746 * Avoid relying on sorting to set the * Addresses PR comments
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Staking: store last min-active-bond on-chain Storing the `min-active-bond` onchain helps the UIs with minimal on-chain costs. Closes paritytech#12746 * Avoid relying on sorting to set the * Addresses PR comments
gpestana
changed the title
min-active-bond on-chain
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing the minimum active stake onchain helps the UIs with minimal on-chain costs.
Closes #12746