Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Adjust the ratio of the in-peers/out-peers #13477

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Conversation

altonen
Copy link
Contributor

@altonen altonen commented Feb 27, 2023

Establish fewer outbound connections in an attempt to allow publicly available nodes to accept more full nodes.

Maintain the overall number of connections node should establish.

Establish fewer outbound connections in an attempt to allow publicly
available nodes to accept more full nodes.

Maintain the overall number of connections node should establish.
@altonen altonen requested review from bkchr and a team February 27, 2023 12:15
@altonen altonen added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes labels Feb 27, 2023
@dmitry-markin
Copy link
Contributor

dmitry-markin commented Feb 27, 2023

Do you think it nevertheless makes sense controlling the number of out connections dynamically depending on the major syncing status?

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@altonen altonen added the T0-node This PR/Issue is related to the topic “node”. label Feb 28, 2023
@altonen
Copy link
Contributor Author

altonen commented Feb 28, 2023

Do you think it nevertheless makes sense controlling the number of out connections dynamically depending on the major syncing status?

I think it would require more research what is appropriate + way for people opt out. I also think it should be anyway be clamped at the lower bound to some sensible value (which is effectively what this PR does). It is sort of a hidden feature which could be improved of course and we can revisit this solution in the (near) future.

@altonen altonen merged commit f2615a4 into master Feb 28, 2023
@altonen altonen deleted the adjust-in-out-peer-ratios branch February 28, 2023 07:52
@gregorst3
Copy link

gregorst3 commented Mar 23, 2023

Hello @altonen @bkchr , after the 0.9.40 update my in/out peer went from 40 to 500. Is this expected?
image

@melekes
Copy link
Contributor

melekes commented Mar 24, 2023

Not 100% sure but this PR #13700 might fix the problem.

ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
Establish fewer outbound connections in an attempt to allow publicly
available nodes to accept more full nodes.

Maintain the overall number of connections node should establish.
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
Establish fewer outbound connections in an attempt to allow publicly
available nodes to accept more full nodes.

Maintain the overall number of connections node should establish.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants