-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
@jsidorenko that looks great! Thanks for adapting so quickly. One question:
|
It's because I'm still learning the labels science :) |
bot rebase |
Rebased |
bot bench $ pallet dev pallet_nfts |
@jsidorenko https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2507636 was started for your command Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looking at the migration.
@jsidorenko Command |
bot bench $ pallet dev pallet_nfts |
@jsidorenko https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2508377 was started for your command Comment |
@jsidorenko Command |
bot merge |
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-40/2468/1 |
* Disallow admin to transfer or burn items he doesn't own * lock_collection should be accessible by collection's owner only * Allow admin to access lock_item_properties() * Fix do_lock_item_properties * Move update_mint_settings() to Issuer * Rename check_owner to check_origin * Typo * Make admin to be in charge of managing the metadata * Make admin the main attributes manager * offchain mint should be signed by Issuer * Remove the special case when the Issuer calls the mint() function * Rework burn and destroy methods * Return back item_metadatas * Don't repatriate the deposit on transfer * A bit more tests * One more test * Add migration * Chore * Clippy * Rename to owned_item * Address comments * Replace .filter_map with .find_map * Improve version validation in pre_upgrade() * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts --------- Co-authored-by: parity-processbot <>
* Disallow admin to transfer or burn items he doesn't own * lock_collection should be accessible by collection's owner only * Allow admin to access lock_item_properties() * Fix do_lock_item_properties * Move update_mint_settings() to Issuer * Rename check_owner to check_origin * Typo * Make admin to be in charge of managing the metadata * Make admin the main attributes manager * offchain mint should be signed by Issuer * Remove the special case when the Issuer calls the mint() function * Rework burn and destroy methods * Return back item_metadatas * Don't repatriate the deposit on transfer * A bit more tests * One more test * Add migration * Chore * Clippy * Rename to owned_item * Address comments * Replace .filter_map with .find_map * Improve version validation in pre_upgrade() * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts --------- Co-authored-by: parity-processbot <>
This PR changes the permissions model in the pallet-nfts:
For simple collections, the same account usually has all the roles.
But if we take complex collections, then each role here represents a separate service with its own responsibilities (e.g. items issuance), and it should be simple to rotate the keys of those services. At the same time, the main owner's account is usually used just to setup the collection and the private key is kept in cold storage afterwards.
Given all that, a bunch of frequently called actions were moved from the Owner role to Admin or Issuer.
So, here is the list of the main actions each role will be able to do:
Owner
Admin
Freezer
Issuer
This PR closes: #13171
Cumulus Companion: paritytech/cumulus#2303