Logic for the (Core) Fellowship #13503

gavofyork · 2023-03-01T12:04:46Z

Closes #13480.
Based on #13378.

Introduces the new Core-Fellowship pallet, which contains logic specific to the (Core) Fellowship, but which could be used in other fellowships also.

Doesn't touch live code so can be merged, but should not be used in Polkadot until after an audit.

TODO

Consider a fn request_proof(info: [u8; 32]) function to record information concerning a proof, and perhaps a similar one for promotion.
Benchmarks
Weights
Ensure there is a script to check overall voting records in line with Fellowship voting requirements.

… HEAD

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

primitives/arithmetic/src/traits.rs

frame/core-fellowship/src/lib.rs

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

… into gav-core-fellowship

ggwpez

Very nice!

frame/core-fellowship/src/lib.rs

frame/core-fellowship/src/benchmarking.rs

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

… into gav-core-fellowship

shawntabrizi · 2023-03-08T03:29:36Z

frame/core-fellowship/src/lib.rs

+				params.offboard_timeout
+			} else {
+				let rank_index = Self::rank_to_index(rank).ok_or(Error::<T, I>::InvalidRank)?;
+				params.demotion_period[rank_index]


just scrolling through, but feels like this should be using get api, which handles if the index does not exist, rather than panic. could happen if bad migrations or something else, idk

rank_to_index guarantees the bound is respected.

frame/core-fellowship/src/lib.rs

vivekvpandya · 2023-03-13T14:19:31Z

Small thing is missing in dependency , causing CI break https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2513783

ggwpez · 2023-03-13T15:31:22Z

Small thing is missing in dependency , causing CI break https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2513783

Yea the dev dependencies should be stripped before publishing. Dont know if anyone is working on that.

* More drafting * Paymaster pallet * Fix build * More tests * Rename * Rename * Renaming * Revert old changes * Multi-phase payouts to avoid bank-runs * Tests * Tests * Allow payment to be targeted elsewhere * Proper ssync payment failure handling * Test for repayment * Docs * Impl RankedMembers for RankedCollective * Implement Pay for Pot (i.e. basic account). * Benchmarks * Weights * Introduce Salary benchmark into node * Fix warning * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_salary * Update primitives/arithmetic/src/traits.rs Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> * Update frame/salary/src/lib.rs Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> * Update lib.rs * Update frame/salary/src/lib.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Docs * Update frame/salary/src/lib.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update frame/salary/src/lib.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Fix * Fixes * Fixes * Move some salary traits stuff to a shared location * Initial draft * Comment out bits * Fix * First couple of tests * One more test * Update frame/salary/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/salary/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Mul floor * Tests * Mul floor * Fix warnings * Fix test * Tests * Last tests * Docs * Fix warnings * Benchmarks * Weights * Integrate benchmark * Fixes * Fix * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship * Better process flow * Fix benchmarks & tests * Docs * Fixes * Fixes * docs * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship * Docs and allow custom evidence size * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship * Update frame/core-fellowship/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/core-fellowship/src/tests.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/core-fellowship/src/benchmarking.rs * Update frame/core-fellowship/src/benchmarking.rs * Apply suggestions from code review * Rename * Update primitives/arithmetic/src/traits.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Reduce magic numbers * Update frame/core-fellowship/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/core-fellowship/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Benchmark result * Remove dependency * set_params should pay * induct should pay * Remove some other free calls --------- Co-authored-by: command-bot <> Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

gavofyork and others added 30 commits October 7, 2022 17:47

More drafting

e3a5bb2

Merge remote-tracking branch 'origin/master' into gav-paymaster

3ff9ce8

Paymaster pallet

07ab87a

Merge remote-tracking branch 'origin/master' into gav-paymaster

88e11ce

Merge remote-tracking branch 'origin/master' into gav-paymaster

8200850

Fix build

958d34f

More tests

91cb1f5

Rename

c53d372

Rename

0806559

Renaming

5cadabf

Revert old changes

712118b

Multi-phase payouts to avoid bank-runs

07b785c

Tests

7fb95d0

Tests

5c38814

Allow payment to be targeted elsewhere

bfdf333

Proper ssync payment failure handling

807a3c9

Test for repayment

cf1f365

Docs

d829078

Impl RankedMembers for RankedCollective

7162964

Implement Pay for Pot (i.e. basic account).

2e299f4

Benchmarks

5995eeb

Weights

c9c2ce8

Introduce Salary benchmark into node

16bc55a

Fix warning

2fc7fab

Merge branch 'master' of https://github.com/paritytech/substrate into…

575f426

… HEAD

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_salary

42a7927

Update primitives/arithmetic/src/traits.rs

7dc1529

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>

Update frame/salary/src/lib.rs

366267c

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>

Update lib.rs

26f1ab0

Update frame/salary/src/lib.rs

872a047

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

gavofyork added 2 commits March 6, 2023 16:24

Apply suggestions from code review

76e521b

Rename

a86c095

joepetrowski reviewed Mar 7, 2023

View reviewed changes

primitives/arithmetic/src/traits.rs Outdated Show resolved Hide resolved

KiChjang reviewed Mar 7, 2023

View reviewed changes

frame/core-fellowship/src/lib.rs Outdated Show resolved Hide resolved

gavofyork and others added 3 commits March 7, 2023 13:00

Update primitives/arithmetic/src/traits.rs

c9de385

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Reduce magic numbers

8684952

Merge branch 'gav-core-fellowship' of github.com:paritytech/substrate…

4fc96dd

… into gav-core-fellowship

ggwpez approved these changes Mar 7, 2023

View reviewed changes

gavofyork and others added 4 commits March 7, 2023 18:12

Update frame/core-fellowship/src/lib.rs

091c6af

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Update frame/core-fellowship/src/lib.rs

ecd0c46

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Benchmark result

749f9ac

Merge branch 'gav-core-fellowship' of github.com:paritytech/substrate…

122df7c

… into gav-core-fellowship

shawntabrizi reviewed Mar 8, 2023

View reviewed changes

frame/core-fellowship/src/lib.rs Outdated Show resolved Hide resolved

shawntabrizi reviewed Mar 8, 2023

View reviewed changes

frame/core-fellowship/src/lib.rs Outdated Show resolved Hide resolved

gavofyork added 4 commits March 8, 2023 09:44

Remove dependency

04da40e

set_params should pay

ae5a5e2

induct should pay

554ac7d

Remove some other free calls

cc9f07c

shawntabrizi approved these changes Mar 8, 2023

View reviewed changes

gavofyork merged commit 9d34fb0 into master Mar 11, 2023

gavofyork deleted the gav-core-fellowship branch March 11, 2023 12:11

kiltbot mentioned this pull request Apr 3, 2023

3️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.39 to 0.9.40 KILTprotocol/kilt-node#496

Closed

librelois mentioned this pull request Apr 6, 2023

Update substrate/polkadot/cumulus from v0.9.38 to v0.9.40 moonbeam-foundation/moonbeam#2200

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

dmitrylavrenov mentioned this pull request Nov 28, 2023

Tracking issue to bump substrate related deps to polkadot-v0.9.40 humanode-network/humanode#839

Closed

46 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logic for the (Core) Fellowship #13503

Logic for the (Core) Fellowship #13503

gavofyork commented Mar 1, 2023 •

edited

Loading

ggwpez left a comment

shawntabrizi Mar 8, 2023

gavofyork Mar 8, 2023

vivekvpandya commented Mar 13, 2023

ggwpez commented Mar 13, 2023

Logic for the (Core) Fellowship #13503

Logic for the (Core) Fellowship #13503

Conversation

gavofyork commented Mar 1, 2023 • edited Loading

TODO

ggwpez left a comment

Choose a reason for hiding this comment

shawntabrizi Mar 8, 2023

Choose a reason for hiding this comment

gavofyork Mar 8, 2023

Choose a reason for hiding this comment

vivekvpandya commented Mar 13, 2023

ggwpez commented Mar 13, 2023

gavofyork commented Mar 1, 2023 •

edited

Loading