Support stable rust for compiling the runtime #13580

bkchr · 2023-03-10T13:02:13Z

This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable.

Closes: #1252

polkadot companion: paritytech/polkadot#6967
cumulus companion: paritytech/cumulus#2393

utils/wasm-builder/src/lib.rs

utils/wasm-builder/src/prerequisites.rs

ggwpez · 2023-03-11T20:42:56Z

So we dont need nightly anymore?
Then we can also finally use a toolchain file for reproducible builds #11307

athei · 2023-03-13T17:06:38Z

So we dont need nightly anymore? Then we can also finally use a toolchain file for reproducible builds #11307

Yes. We don't need nightly anymore (except for fmt). But this also removes the problem of using the "wrong" nightly. Hence the toolchain file is not necessary. New stable version will not break the code as nightly does. We just need to specify the minimum Rust version in our manifests.

The toolchain file won't make reproducible builds happen. Just using the same compiler does not make the build reproducible. You still need docker for this.

melekes · 2023-03-14T07:38:11Z

utils/wasm-builder/src/lib.rs

+impl Version {
+	/// Returns if `self` is older than `other`.
+	fn is_older(&self, other: &Self) -> bool {
+		self.major < other.major || self.minor < other.minor || self.patch < other.patch


3.2.1 - 2.4.1 will report true even though 2.4.1 is older. I think this should be smth like

self.major < other.major || (self.major == other.major && self.minor < other.minor) || (self.major == other.major && self.minor == other.minor && self.patch < other.patch)

This should also compare dates if the versions are equal, as the versions (for nightlies) can quite easily be the same e.g.:

$ rustup run nightly-2023-02-14-x86_64-unknown-linux-gnu rustc --version rustc 1.69.0-nightly (065852def 2023-02-13) $ rustup run nightly-2023-01-24-x86_64-unknown-linux-gnu rustc --version rustc 1.69.0-nightly (c8e6a9e8b 2023-01-23)

This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable.

* Support stable rust for compiling the runtime This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable. * We always support nightlies! * 🤦 * Sort by version * Review feedback * Review feedback * Fix version parsing * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: Koute <koute@users.noreply.github.com>

This reverts commit 0b985aa.

…ntract termination (#13702) * [Contracts review] Overflowing bounded `DeletionQueue` allows DoS against contract termination * wip * wip * wip * wip * wip * fix doc * wip * PR review * unbreak tests * fixes * update budget computation * PR comment: use BlockWeights::get().max_block * PR comment: Update queue_trie_for_deletion signature * PR comment: update deletion budget docstring * PR comment: impl Default with derive(DefaultNoBound) * PR comment: Remove DeletedContract * PR comment Add ring_buffer test * remove missed comment * misc comments * contracts: add sr25519_recover * Revert "contracts: add sr25519_recover" This reverts commit d4600e0. * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts * PR comments update print_schedule * Update frame/contracts/src/benchmarking/mod.rs * Update frame/contracts/src/storage.rs * Update frame/contracts/src/storage.rs * rm temporary fixes * fix extra ; * Update frame/contracts/src/storage.rs Co-authored-by: juangirini <juangirini@gmail.com> * Update frame/contracts/src/storage.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Update frame/contracts/src/lib.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Update frame/contracts/src/lib.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Support stable rust for compiling the runtime (#13580) * Support stable rust for compiling the runtime This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable. * We always support nightlies! * 🤦 * Sort by version * Review feedback * Review feedback * Fix version parsing * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: Koute <koute@users.noreply.github.com> * github PR commit fixes * Revert "Support stable rust for compiling the runtime (#13580)" This reverts commit 0b985aa. * Restore DeletionQueueMap * fix namings * PR comment * move comments * Update frame/contracts/src/storage.rs * Update frame/contracts/src/storage.rs * fixes --------- Co-authored-by: command-bot <> Co-authored-by: juangirini <juangirini@gmail.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Koute <koute@users.noreply.github.com>

* Support stable rust for compiling the runtime This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable. * We always support nightlies! * 🤦 * Sort by version * Review feedback * Review feedback * Fix version parsing * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: Koute <koute@users.noreply.github.com>

…ntract termination (#13702) * [Contracts review] Overflowing bounded `DeletionQueue` allows DoS against contract termination * wip * wip * wip * wip * wip * fix doc * wip * PR review * unbreak tests * fixes * update budget computation * PR comment: use BlockWeights::get().max_block * PR comment: Update queue_trie_for_deletion signature * PR comment: update deletion budget docstring * PR comment: impl Default with derive(DefaultNoBound) * PR comment: Remove DeletedContract * PR comment Add ring_buffer test * remove missed comment * misc comments * contracts: add sr25519_recover * Revert "contracts: add sr25519_recover" This reverts commit d4600e0. * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts * PR comments update print_schedule * Update frame/contracts/src/benchmarking/mod.rs * Update frame/contracts/src/storage.rs * Update frame/contracts/src/storage.rs * rm temporary fixes * fix extra ; * Update frame/contracts/src/storage.rs Co-authored-by: juangirini <juangirini@gmail.com> * Update frame/contracts/src/storage.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Update frame/contracts/src/lib.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Update frame/contracts/src/lib.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Support stable rust for compiling the runtime (#13580) * Support stable rust for compiling the runtime This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable. * We always support nightlies! * 🤦 * Sort by version * Review feedback * Review feedback * Fix version parsing * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: Koute <koute@users.noreply.github.com> * github PR commit fixes * Revert "Support stable rust for compiling the runtime (#13580)" This reverts commit 0b985aa. * Restore DeletionQueueMap * fix namings * PR comment * move comments * Update frame/contracts/src/storage.rs * Update frame/contracts/src/storage.rs * fixes --------- Co-authored-by: command-bot <> Co-authored-by: juangirini <juangirini@gmail.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Koute <koute@users.noreply.github.com>

* Support stable rust for compiling the runtime This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable. * We always support nightlies! * 🤦 * Sort by version * Review feedback * Review feedback * Fix version parsing * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: Koute <koute@users.noreply.github.com>

ntn-x2 · 2023-04-14T11:51:59Z

Great news! What's the earliest Substrate/Polkadot release that include this commit?

bkchr · 2023-04-14T14:39:09Z

It should come with 0.9.42

* Support stable rust for compiling the runtime This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable. * We always support nightlies! * 🤦 * Sort by version * Review feedback * Review feedback * Fix version parsing * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: Koute <koute@users.noreply.github.com>

…ntract termination (#13702) * [Contracts review] Overflowing bounded `DeletionQueue` allows DoS against contract termination * wip * wip * wip * wip * wip * fix doc * wip * PR review * unbreak tests * fixes * update budget computation * PR comment: use BlockWeights::get().max_block * PR comment: Update queue_trie_for_deletion signature * PR comment: update deletion budget docstring * PR comment: impl Default with derive(DefaultNoBound) * PR comment: Remove DeletedContract * PR comment Add ring_buffer test * remove missed comment * misc comments * contracts: add sr25519_recover * Revert "contracts: add sr25519_recover" This reverts commit d4600e0. * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts * PR comments update print_schedule * Update frame/contracts/src/benchmarking/mod.rs * Update frame/contracts/src/storage.rs * Update frame/contracts/src/storage.rs * rm temporary fixes * fix extra ; * Update frame/contracts/src/storage.rs Co-authored-by: juangirini <juangirini@gmail.com> * Update frame/contracts/src/storage.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Update frame/contracts/src/lib.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Update frame/contracts/src/lib.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Support stable rust for compiling the runtime (#13580) * Support stable rust for compiling the runtime This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable. * We always support nightlies! * 🤦 * Sort by version * Review feedback * Review feedback * Fix version parsing * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: Koute <koute@users.noreply.github.com> * github PR commit fixes * Revert "Support stable rust for compiling the runtime (#13580)" This reverts commit 0b985aa. * Restore DeletionQueueMap * fix namings * PR comment * move comments * Update frame/contracts/src/storage.rs * Update frame/contracts/src/storage.rs * fixes --------- Co-authored-by: command-bot <> Co-authored-by: juangirini <juangirini@gmail.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Koute <koute@users.noreply.github.com>

* Support stable rust for compiling the runtime This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable. * We always support nightlies! * 🤦 * Sort by version * Review feedback * Review feedback * Fix version parsing * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: Koute <koute@users.noreply.github.com>

deepink-mas · 2023-06-09T13:08:02Z

This breaks my build, see #14335.
Version::extract("cargo 1.69.0-nightly").unwrap(); // panicked at 'called Option::unwrap() on a None value'

* Support stable rust for compiling the runtime This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable. * We always support nightlies! * 🤦 * Sort by version * Review feedback * Review feedback * Fix version parsing * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: Koute <koute@users.noreply.github.com>

…ntract termination (paritytech#13702) * [Contracts review] Overflowing bounded `DeletionQueue` allows DoS against contract termination * wip * wip * wip * wip * wip * fix doc * wip * PR review * unbreak tests * fixes * update budget computation * PR comment: use BlockWeights::get().max_block * PR comment: Update queue_trie_for_deletion signature * PR comment: update deletion budget docstring * PR comment: impl Default with derive(DefaultNoBound) * PR comment: Remove DeletedContract * PR comment Add ring_buffer test * remove missed comment * misc comments * contracts: add sr25519_recover * Revert "contracts: add sr25519_recover" This reverts commit d4600e0. * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts * PR comments update print_schedule * Update frame/contracts/src/benchmarking/mod.rs * Update frame/contracts/src/storage.rs * Update frame/contracts/src/storage.rs * rm temporary fixes * fix extra ; * Update frame/contracts/src/storage.rs Co-authored-by: juangirini <juangirini@gmail.com> * Update frame/contracts/src/storage.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Update frame/contracts/src/lib.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Update frame/contracts/src/lib.rs Co-authored-by: Alexander Theißen <alex.theissen@me.com> * Support stable rust for compiling the runtime (paritytech#13580) * Support stable rust for compiling the runtime This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable. * We always support nightlies! * 🤦 * Sort by version * Review feedback * Review feedback * Fix version parsing * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: Koute <koute@users.noreply.github.com> * github PR commit fixes * Revert "Support stable rust for compiling the runtime (paritytech#13580)" This reverts commit 0b985aa. * Restore DeletionQueueMap * fix namings * PR comment * move comments * Update frame/contracts/src/storage.rs * Update frame/contracts/src/storage.rs * fixes --------- Co-authored-by: command-bot <> Co-authored-by: juangirini <juangirini@gmail.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Koute <koute@users.noreply.github.com>

* Support stable rust for compiling the runtime This pull request brings support for compiling the runtime with stable Rust. This requires at least rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and should automatically work when someone compiles with 1.68.0+ stable. * We always support nightlies! * 🤦 * Sort by version * Review feedback * Review feedback * Fix version parsing * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> --------- Co-authored-by: Koute <koute@users.noreply.github.com>

bkchr requested a review from koute as a code owner March 10, 2023 13:02

This was referenced Mar 10, 2023

wasm-builder: Always build runtime with the toolchain used for the outer build #13579

Closed

Compile the wasm runtime with a stable toolchain #1252

Closed

bkchr added B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. and removed B0-silent Changes should not be mentioned in any release notes labels Mar 10, 2023

koute reviewed Mar 10, 2023

View reviewed changes

utils/wasm-builder/src/lib.rs Outdated Show resolved Hide resolved

utils/wasm-builder/src/lib.rs Outdated Show resolved Hide resolved

utils/wasm-builder/src/prerequisites.rs Outdated Show resolved Hide resolved

bkchr requested a review from a team March 13, 2023 14:31

athei mentioned this pull request Mar 13, 2023

Explicit definition of required rust toolchain #11307

Open

athei approved these changes Mar 13, 2023

View reviewed changes

melekes reviewed Mar 14, 2023

View reviewed changes

nazar-pc mentioned this pull request Mar 15, 2023

Make snowbridge-ethereum-beacon-client generic over the network it is built for Snowfork/snowbridge#788

Closed

max-sixty mentioned this pull request Mar 19, 2023

Playground build is slow, even without changes PRQL/prql#2158

Closed

PopcornPaws mentioned this pull request Mar 20, 2023

I116 unapprove validators guildxyz/guild-network#117

Merged

max-sixty mentioned this pull request Mar 23, 2023

Replace wasm-pack PRQL/prql#1836

Open

bkchr requested review from koute and melekes March 27, 2023 15:39

bkchr added 6 commits March 27, 2023 17:47

We always support nightlies!

41cdf0a

🤦

8cb2813

Sort by version

1ad8514

Review feedback

2e7cd85

Review feedback

40759f3

bkchr force-pushed the bkchr-support-rust-stable-for-wasm branch from 0677690 to 40759f3 Compare March 27, 2023 15:48

pgherveou added a commit that referenced this pull request Mar 30, 2023

Revert "Support stable rust for compiling the runtime (#13580)"

6b31f97

This reverts commit 0b985aa.

Dengjianping mentioned this pull request Mar 31, 2023

Build WASM runtimes with stable rust Manta-Network/Manta#673

Open

ggwpez mentioned this pull request Mar 31, 2023

Update the nix build configuration. #13706

Merged

15 tasks

librelois mentioned this pull request Apr 4, 2023

Switch to stable rust and make rust debug build usable moonbeam-foundation/moonbeam#2207

Merged

bkchr mentioned this pull request Apr 24, 2023

error[E0557]: feature has been removed|#![cfg_attr(not(feature = "std"), feature(alloc_error_handler))] #13986

Closed

2 tasks

jasl mentioned this pull request May 11, 2023

Upgrade to Polkadot v0.9.42 Phala-Network/phala-blockchain#1263

Merged

max-sixty mentioned this pull request May 12, 2023

"target/debug/deps" grows every time run task run-book PRQL/prql#2566

Closed

2 tasks

kalaninja mentioned this pull request May 24, 2023

Install wasm target into nightly toolchain paritytech/scripts#562

Merged

deepink-mas mentioned this pull request Jun 9, 2023

Latest node template fails to build #14335

Closed

2 tasks

github-actions bot mentioned this pull request Jun 15, 2023

Update substrate/polkadot/cumulus from v0.9.40 to v0.9.43 moonbeam-foundation/moonbeam#2354

Closed

mattheworris mentioned this pull request Jun 15, 2023

Support stable rust for compiling the runtime frequency-chain/frequency#1605

Closed

weezy20 mentioned this pull request Jun 22, 2023

Improve Github Actions paritytech/extended-parachain-template#35

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

Kailai-Wang mentioned this pull request Jun 26, 2023

Building wasm with srtool fails litentry/litentry-parachain#1819

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support stable rust for compiling the runtime #13580

Support stable rust for compiling the runtime #13580

bkchr commented Mar 10, 2023 •

edited

Loading

ggwpez commented Mar 11, 2023

athei commented Mar 13, 2023 •

edited

Loading

melekes Mar 14, 2023

koute Mar 14, 2023

bkchr Mar 14, 2023

ntn-x2 commented Apr 14, 2023

bkchr commented Apr 14, 2023

deepink-mas commented Jun 9, 2023

Support stable rust for compiling the runtime #13580

Support stable rust for compiling the runtime #13580

Conversation

bkchr commented Mar 10, 2023 • edited Loading

ggwpez commented Mar 11, 2023

athei commented Mar 13, 2023 • edited Loading

melekes Mar 14, 2023

Choose a reason for hiding this comment

koute Mar 14, 2023

Choose a reason for hiding this comment

bkchr Mar 14, 2023

Choose a reason for hiding this comment

ntn-x2 commented Apr 14, 2023

bkchr commented Apr 14, 2023

deepink-mas commented Jun 9, 2023

bkchr commented Mar 10, 2023 •

edited

Loading

athei commented Mar 13, 2023 •

edited

Loading