-
Notifications
You must be signed in to change notification settings - Fork 2.6k
contracts: Add host function tracing #13648
Conversation
Note to self, this can be tested directly from substrate kitchensink node by running cargo run --release -- --dev -l "fatal,runtime::contracts::strace=trace" I lost quite some time updating and patching substrate-contracts-node, to run it against my local changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
44970f7
to
9d04d6b
Compare
bot bench $ pallet pallet_contracts |
@pgherveou https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2578878 was started for your command Comment |
@pgherveou Command |
@athei kitchensink-runtime size before and after ls -alg "target/release/wbuild/kitchensink-runtime/kitchensink_runtime.compact.compressed.wasm"
|
I think the size grow is within expectation 👍 |
bot bench $ pallet dev pallet_contracts |
@pgherveou https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2579580 was started for your command Comment |
@pgherveou Command |
9f94b84
to
2fe9545
Compare
Weight looks good. Just the benchmarks who are always fluctuating are fluctuating: |
ah nice I was going to ask you how to visualize the diff easily, will bookmark this link! |
Any tips on how to fix issues with |
It either happens because you changed an API that was used by cumulus or someone else did and the companion wasn't merged, yet. What you can do in the latter case (which applies here): Merge master when the companion was merged. |
Co-authored-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just suggested a small DRYing
Fix: #13593
TODO:
Compare sizes of the kitchensink runtime before and after the change
Checkin the kitchensink-runtime size before and after
ls -algh "target/release/wbuild/kitchensink-runtime/kitchensink_runtime.compact.compressed.wasm"