Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove wasmi backend from sc-executor #13800

Merged
merged 45 commits into from
May 23, 2023
Merged

Remove wasmi backend from sc-executor #13800

merged 45 commits into from
May 23, 2023

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Apr 2, 2023 •
edited by bkchr
Loading

This pull request removes the wasmi backend. This means that the runtime can not be run with an interpreter anymore. Runtime execution will then exclusively wasmtime.

Closes #13496.

polkadot address: 15ouFh2SHpGbHtDPsJ6cXQfes9Cx1gEFnJJsJVqPGzBSTudr

yjhmelody added 30 commits March 29, 2023 00:31
@yjhmelody
refactor: use builder api for all executors
0edd825
@yjhmelody
improve a lot
9750b54
@yjhmelody
remove unused args
de50bf8
@yjhmelody
cleanup deps
fb0539d
@yjhmelody
fix inconsistency about heap alloc
b60bbd8
@yjhmelody
add heap_pages back to try-runtime
4eb0dc2
@yjhmelody
fix
f449134
@yjhmelody
chore: reduce duplicated code for sc-service-test
c4175b2
@yjhmelody
cleanup code
86172e6
@yjhmelody
fmt
f2c2e54
@yjhmelody
improve test executor
ce6dfb6
@yjhmelody
improve
95dca94
@yjhmelody
Merge branch 'master' into refactor-use-executor-builder
cd3bacb
@yjhmelody
Merge branch 'master' into refactor-use-executor-builder
c22e1bf
@yjhmelody
use #[deprecated]
7147033
@yjhmelody
set runtime_cache_size: 4
157646e
@yjhmelody
wip
3f43381
@yjhmelody
fix and improve
2dfbe0e
@yjhmelody
Merge branch 'refactor-use-executor-builder' into refactor-remove-wasmi
48161e5
@yjhmelody
remove sc-executor-wasmi deps
3659412
@yjhmelody
clean up bench and tests
9e068da
@yjhmelody
delete "client/executor/wasmi"
16d2e5a
@yjhmelody
cleanup
18bbf96
@yjhmelody
refactor builder
31ac181
@yjhmelody
fix
d4cacc0
@yjhmelody
fix bench
7054f42
@yjhmelody
fix tests
fd173f6
@yjhmelody
fix warnings
c523c6e
@yjhmelody
fix warnings
68661c0
@yjhmelody
fix
00bc047
@yjhmelody
Copy link
Contributor Author

yjhmelody commented May 19, 2023 •
edited
Loading

we need a cumulus companion please.

Ok, let me try. But I do not know how to use this branch for cumulus.

@yjhmelody yjhmelody mentioned this pull request May 19, 2023
Merged
@michalkucharczyk
Copy link
Contributor

you need to put cumulus companion: into description

@bkchr
Copy link
Member

bkchr commented May 19, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 1b7375a

@bkchr
Copy link
Member

bkchr commented May 21, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkchr
Copy link
Member

bkchr commented May 21, 2023

bot merge

@paritytech-processbot
Copy link

Error: Github API says paritytech/cumulus#2599 is not mergeable

@koute koute mentioned this pull request May 22, 2023
Merged
@yjhmelody
Copy link
Contributor Author

Hi @bkchr Need a retry to merge it.

@koute
Copy link
Contributor

koute commented May 23, 2023

@yjhmelody I retried the job but it still fails; looks like you have to update your companion.

@yjhmelody
Copy link
Contributor Author

@koute The companion should be merged firstly and then no need companion PR more. Because the companion PR in cumulus not really need to update substrate commits.

@yjhmelody yjhmelody mentioned this pull request May 23, 2023
Merged
@koute
Copy link
Contributor

koute commented May 23, 2023

@koute The companion should be merged firstly and then no need companion PR more. Because the companion PR in cumulus not really need to update substrate commits.

Yeah, that works too. Let's do that.

@bkchr bkchr merged commit 4dd06e4 into paritytech:master May 23, 2023
@bkchr
Copy link
Member

bkchr commented May 23, 2023

/tip small

@substrate-tip-bot
Copy link

@bkchr A small tip was successfully submitted for @yjhmelody (15ouFh2SHpGbHtDPsJ6cXQfes9Cx1gEFnJJsJVqPGzBSTudr on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips tip

@altonen altonen mentioned this pull request May 24, 2023
Merged
gpestana pushed a commit that referenced this pull request May 27, 2023
@yjhmelody @bkchr @gpestana
Remove wasmi backend from sc-executor (#13800)
0ed6d19 
* refactor: use builder api for all executors

* improve a lot

* remove unused args

* cleanup deps

* fix inconsistency about heap alloc

* add `heap_pages` back to try-runtime

* fix

* chore: reduce duplicated code for sc-service-test

* cleanup code

* fmt

* improve test executor

* improve

* use #[deprecated]

* set runtime_cache_size: 4

* wip

* fix and improve

* remove sc-executor-wasmi deps

* clean up bench and tests

* delete "client/executor/wasmi"

* cleanup

* refactor builder

* fix

* fix bench

* fix tests

* fix warnings

* fix warnings

* fix

* fix

* remove wasmi and fix tests

* unused imports

* improve by suggestions

* Update client/cli/src/arg_enums.rs

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
Ank4n pushed a commit that referenced this pull request Jul 8, 2023
@yjhmelody @bkchr @Ank4n
Remove wasmi backend from sc-executor (#13800)
9c360ab 
* refactor: use builder api for all executors

* improve a lot

* remove unused args

* cleanup deps

* fix inconsistency about heap alloc

* add `heap_pages` back to try-runtime

* fix

* chore: reduce duplicated code for sc-service-test

* cleanup code

* fmt

* improve test executor

* improve

* use #[deprecated]

* set runtime_cache_size: 4

* wip

* fix and improve

* remove sc-executor-wasmi deps

* clean up bench and tests

* delete "client/executor/wasmi"

* cleanup

* refactor builder

* fix

* fix bench

* fix tests

* fix warnings

* fix warnings

* fix

* fix

* remove wasmi and fix tests

* unused imports

* improve by suggestions

* Update client/cli/src/arg_enums.rs

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@yjhmelody @bkchr @nathanwhit
Remove wasmi backend from sc-executor (paritytech#13800)
0e90dec 
* refactor: use builder api for all executors

* improve a lot

* remove unused args

* cleanup deps

* fix inconsistency about heap alloc

* add `heap_pages` back to try-runtime

* fix

* chore: reduce duplicated code for sc-service-test

* cleanup code

* fmt

* improve test executor

* improve

* use #[deprecated]

* set runtime_cache_size: 4

* wip

* fix and improve

* remove sc-executor-wasmi deps

* clean up bench and tests

* delete "client/executor/wasmi"

* cleanup

* refactor builder

* fix

* fix bench

* fix tests

* fix warnings

* fix warnings

* fix

* fix

* remove wasmi and fix tests

* unused imports

* improve by suggestions

* Update client/cli/src/arg_enums.rs

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
@yjhmelody yjhmelody deleted the refactor-remove-wasmi branch September 30, 2023 01:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@koute koute koute approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove wasmi as sc-executor backend
5 participants
@yjhmelody @gshep @koute @bkchr @michalkucharczyk