Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Make blocks per request configurable #13824

Merged
merged 5 commits into from
Apr 7, 2023
Merged

Make blocks per request configurable #13824

merged 5 commits into from
Apr 7, 2023

Conversation

altonen
Copy link
Contributor

@altonen altonen commented Apr 5, 2023

Resolves #10130

@altonen altonen added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes labels Apr 5, 2023
@altonen altonen requested a review from a team April 5, 2023 07:51
@altonen altonen added the T0-node This PR/Issue is related to the topic “node”. label Apr 5, 2023
melekes
melekes approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

client/cli/src/params/network_params.rs Show resolved Hide resolved
@altonen
Copy link
Contributor Author

altonen commented Apr 7, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit d443f14 into master Apr 7, 2023
@paritytech-processbot paritytech-processbot bot deleted the sync-configure-block-count branch April 7, 2023 08:20
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/april-updates-for-substrate-and-polkadot-devs/2764/1

@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@altonen @nathanwhit
Make blocks per request configurable (paritytech#13824)
b702a30 
* Make blocks per request configurable

* Correct type

* Update docs

* Update client/cli/src/params/network_params.rs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmitry-markin dmitry-markin dmitry-markin approved these changes

@bkchr bkchr bkchr left review comments

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
Networking
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lost peers due to state-cache
5 participants
@altonen @Polkadot-Forum @melekes @bkchr @dmitry-markin