Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Clears Old Storage for Session pallet #13997

Closed
wants to merge 1 commit into from

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Apr 25, 2023

Fixes paritytech/polkadot#4691

The old migration didn't clear the data properly. This PR adds a V2 to clear everything under Session::HistoricalSessions and Session::StoredRange

polkadot companion: paritytech/polkadot#7132

@gupnik gupnik added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”. labels Apr 25, 2023
@gupnik gupnik requested review from kianenigma, bkchr and ggwpez April 25, 2023 04:19
@bkchr
Copy link
Member

bkchr commented Apr 25, 2023

As we just missed a migration while migrating to the pallet macro version of the pallet, we don't need the migration here in Substrate. This is a chain specific migration, a migration that needs to be run once and can be put into the Polkadot/Kusama runtimes directly.

@gupnik gupnik closed this Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccessible data stored at session pallet
2 participants