This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Manual seal delayed finalize #13999
Merged
Manual seal delayed finalize #13999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Apr 25, 2023
| @@ -303,6 +321,42 @@ pub async fn run_instant_seal_and_finalize<B, BI, CB, E, C, TP, SC, CIDP, P>( | |||
| .await | |||
| } | |||
|
|
|||
| pub async fn run_delayed_finalize<B, CB, C, S>( | |||
There was a problem hiding this comment.
Some docs on how to use it. A "real" example would be really nice, but at least saying that you don't set finalize in the command stream etc.
|
@bkchr Thank you for the review, I updated the corresponding parts. |
bkchr
approved these changes
Apr 25, 2023
bkchr
added
A0-please_review
|
bot rebase |
|
Rebased |
melekes
reviewed
May 2, 2023
…ubstrate into manual-seal-delayed-finalize
|
@melekes Thank you for adding comments. updated docs. |
gpestana
pushed a commit
that referenced
this pull request
May 4, 2023
* up * up * added test * remove unncessary dep * cargo fmt * cargo fmt * up * Update client/consensus/manual-seal/src/lib.rs Co-authored-by: Bastian Köcher <git@kchr.de> * fix test * cargo fmt * added docs * updated doc --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: parity-processbot <>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* up * up * added test * remove unncessary dep * cargo fmt * cargo fmt * up * Update client/consensus/manual-seal/src/lib.rs Co-authored-by: Bastian Köcher <git@kchr.de> * fix test * cargo fmt * added docs * updated doc --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: parity-processbot <>
Open
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves paritytech/substrate-contracts-node#160
(Before integration to substrate-contract-node, upstream changes in substrate required.)
Adding delayed block finalization for instant block sealing consensus. This is needed for the local development node such as substrate-contract-node, swanky-node.
Instant finalization causes difficulties for frontend development, it is necessary for them to configure the delayed time for block finalization after blocks are imported.
An integration example for actual node can be found here inkdevhub/swanky-node#61.