Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Timeout only if the referendum is not queued #14106

Merged
merged 2 commits into from
May 10, 2023
Merged

Timeout only if the referendum is not queued #14106

merged 2 commits into from
May 10, 2023

Conversation

gavofyork
Copy link
Member

Right now a referendum is cancelled if the track is so busy that the deciding timeout elapses regardless of whether it is queued or not. This isn't especially sensible. We alter it so that it will only be cancelled if the timeout elapses and it is not queued (i.e. the deciding deposit is not paid).

@gavofyork gavofyork requested a review from a team May 9, 2023 15:18
@gavofyork gavofyork added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels May 9, 2023
@juangirini
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented May 9, 2023 •
edited
Loading

@juangirini https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2808443 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 34-272c9114-f8e4-4f1b-9897-ff70425028f2 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 9, 2023

@juangirini Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2808443 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2808443/artifacts/download.

@gavofyork
Copy link
Member Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 14855e6 into master May 10, 2023
@paritytech-processbot paritytech-processbot bot deleted the gav-timeout-only-unqueued branch May 10, 2023 09:41
niklasad1 pushed a commit that referenced this pull request May 17, 2023
@gavofyork @niklasad1
Timeout only if the referendum is not queued (#14106)
c360e4b 
* Timeout only if the referendum is not queued

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@gavofyork @nathanwhit
Timeout only if the referendum is not queued (paritytech#14106)
53b70ee 
* Timeout only if the referendum is not queued

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavofyork @juangirini @sam0x17 @franciscoaguirre