Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove the Copy bound on CollectionId in the uniques pallet #14111

Merged
merged 2 commits into from
May 10, 2023

Conversation

koute
Copy link
Contributor

@koute koute commented May 10, 2023

This PR relaxes the requirement that the CollectionId in the uniques pallet must be Copy.

Motivation

I'm planning to make AssetId/MultiLocation types in polkadot non-Copy (to reduce the size of those types by almost ~90%), and there's at least one crate in polkadot which uses those types as a CollectionId.

@koute koute added A0-please_review Pull request needs code review. I7-refactor Code needs refactoring. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 10, 2023
@koute koute requested review from ggwpez and a team May 10, 2023 06:46
@koute koute requested a review from jsidorenko as a code owner May 10, 2023 06:46
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ItemId has the same thing going on. Not sure if that will annoy you later on as well.

@koute
Copy link
Contributor Author

koute commented May 10, 2023

ItemId has the same thing going on. Not sure if that will annoy you later on as well.

Yeah, I don't know yet. (: I'll be doing this as I go through the compile errors that I encounter, and if I do I'll make another PR. (It's good to keep these PRs small anyway.)

@koute
Copy link
Contributor Author

koute commented May 10, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 725208a into paritytech:master May 10, 2023
niklasad1 pushed a commit that referenced this pull request May 17, 2023
* Remove the `Copy` bound on `CollectionId` in the uniques pallet

* Also add `clone`s in benchmarks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…tytech#14111)

* Remove the `Copy` bound on `CollectionId` in the uniques pallet

* Also add `clone`s in benchmarks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I7-refactor Code needs refactoring.
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants