This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Introduce entropy function into frame System
#14149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
2 tasks
juangirini
approved these changes
May 15, 2023
ggwpez
approved these changes
May 15, 2023
| @@ -1316,6 +1317,8 @@ impl<T: Config> Pallet<T> { | |||
| // populate environment | |||
| ExecutionPhase::<T>::put(Phase::Initialization); | |||
| storage::unhashed::put(well_known_keys::EXTRINSIC_INDEX, &0u32); | |||
| let entropy = (b"frame_system::initialize", parent_hash).using_encoded(blake2_256); | |||
| storage::unhashed::put(well_known_keys::INTRABLOCK_ENTROPY, &entropy[..]); | |||
There was a problem hiding this comment.
Suggested change
| storage::unhashed::put(well_known_keys::INTRABLOCK_ENTROPY, &entropy[..]); | |
| storage::unhashed::put_raw(well_known_keys::INTRABLOCK_ENTROPY, &entropy[..]); |
Otherwise put encodes again and pretends the length, so it looses one byte of entropy when only reading the first 32 bytes.
There was a problem hiding this comment.
Just linking to PR addressing this: #14152
There was a problem hiding this comment.
fixed lengths arrays are not prepended with its length.
There was a problem hiding this comment.
It is a slice though, because of the [..] i assume.
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
Open
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stateless function which provides a universally unique datum, suitable for use in XCM to provide each message with an unpredictable-but-unique identifier across the consensus universe. It may have other uses across the ecosystem.