This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
expose setting kademlia replication factor through node CLI #14391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altonen
added
A0-please_review
altonen
approved these changes
Jun 15, 2023
frame/democracy/src/migrations/unlock_and_unreserve_all_funds.rs
Outdated
Show resolved
Hide resolved
frame/elections-phragmen/src/migrations/unlock_and_unreserve_all_funds.rs
Outdated
Show resolved
Hide resolved
dmitry-markin
approved these changes
Jun 15, 2023
bkchr
reviewed
Jun 15, 2023
Co-authored-by: Bastian Köcher <git@kchr.de>
altonen
reviewed
Jun 16, 2023
bkchr
approved these changes
Jun 21, 2023
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…ch#14391) * expose kademlia replication factor through node CLI * set default CLI flag value for kademlia_replication_factor Co-authored-by: Bastian Köcher <git@kchr.de> * wrap CLI value as Option * make kademlia replication factor non-optional --------- Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Exposes setting Kademlia replication factor through node's CLI.
Why?
Default Kademlia replication factor is 20. In environments (testing for example) with less than 20 nodes
AuthorityDiscoveryfails to publish DHT records containing node'sMultiaddrs. So to makeAuthorityDiscoverywork in test environments it's useful to have option to manually adjust Kademlia replication factor.