Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

sc-network: Improve invalid boot node reporting #14455

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jun 24, 2023

This improves the reporting of invalid boot nodes. First, it will only report each boot node once as invalid and not every time we try to connect to the node. Second, the node will only report for addresses that we added as startup and not for addresses of the boot node that the node learned from other nodes.

Closes: #13584
Closes: paritytech/polkadot#7385

This improves the reporting of invalid boot nodes. First, it will only report each boot node once
as invalid and not every time we try to connect to the node. Second, the node will only report for
addresses that we added as startup and not for addresses of the boot node that the node learned from
other nodes.

Closes: #13584
Closes: paritytech/polkadot#7385
@bkchr bkchr added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. labels Jun 24, 2023
@bkchr bkchr requested a review from a team June 24, 2023 22:46
@altonen altonen requested a review from a team June 26, 2023 07:02
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Maharacha
Copy link

This is highly appreciated! 👍

@bkchr bkchr merged commit aacc6ca into master Jun 28, 2023
@bkchr bkchr deleted the bkchr-network-boot-nodes-reporting branch June 28, 2023 11:21
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
This improves the reporting of invalid boot nodes. First, it will only report each boot node once
as invalid and not every time we try to connect to the node. Second, the node will only report for
addresses that we added as startup and not for addresses of the boot node that the node learned from
other nodes.

Closes: paritytech#13584
Closes: paritytech/polkadot#7385
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodes using the wrong bootnode address Stop trying to connect to broken bootnodes
4 participants