Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

change HashFor to HashingFor #14483

Merged
merged 5 commits into from
Jul 25, 2023
Merged

change HashFor to HashingFor #14483

merged 5 commits into from
Jul 25, 2023

Conversation

deepink-mas
Copy link
Contributor

@deepink-mas deepink-mas commented Jun 30, 2023 •
edited by bkchr
Loading

fixes #10386

Patch created using:
find * -name '.*' -prune -o -name '*.rs' -type f -execdir sed -i -- 's#HashFor#HashingFor#g' '{}' +

polkadot companion: paritytech/polkadot#7465
cumulus companion: paritytech/cumulus#2828

@deepink-mas deepink-mas requested a review from andresilva as a code owner June 30, 2023 06:29
@deepink-mas deepink-mas requested a review from a team June 30, 2023 06:29
@deepink-mas deepink-mas requested a review from cheme as a code owner June 30, 2023 06:29
@deepink-mas deepink-mas requested a review from a team June 30, 2023 06:29
@deepink-mas deepink-mas mentioned this pull request Jun 30, 2023
Closed
@bkchr
Copy link
Member

bkchr commented Jun 30, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Jun 30, 2023 •
edited
Loading

@bkchr https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3096198 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-6d2ba091-b33e-4ea2-a797-6894568fd056 to cancel this command or bot cancel to cancel all commands in this pull request.

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes T2-API This PR/Issue is related to APIs. labels Jun 30, 2023
@command-bot
Copy link

command-bot bot commented Jun 30, 2023

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3096198 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3096198/artifacts/download.

@ggwpez
Copy link
Member

ggwpez commented Jun 30, 2023

Next time if you want to rebase, just do git merge origin/master and then push that.

@bkchr
Copy link
Member

bkchr commented Jun 30, 2023

@deepink-mas this also requires a Cumulus/Polkadot companion.

This was referenced Jul 5, 2023
Merged
Merged
@deepink-mas
Copy link
Contributor Author

Companions for Cumulus/Polkadot: paritytech/polkadot#7465 and paritytech/cumulus#2828

@bkchr bkchr requested a review from ggwpez July 6, 2023 14:52
@deepink-mas
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Jul 12, 2023

@deepink-mas Requester could not be detected as a member of an allowed organization.

@deepink-mas deepink-mas force-pushed the hashfor-to-hashingfor branch 2 times, most recently from 924c2ab to be51c26 Compare July 12, 2023 10:20
@deepink-mas deepink-mas force-pushed the hashfor-to-hashingfor branch from be51c26 to 6f2a834 Compare July 12, 2023 12:26
@deepink-mas
Copy link
Contributor Author

I did a 'cargo fmt' with rust 1.70, but it still seems to contain unrelated formatting changes, which is why I avoided doing it until now. And looking at the CI it seems to want to revert some of those unrelated changes.

Not sure what is going on, unless there is some configuration file that my cargo is not picking up for some reason.

@bkchr
Copy link
Member

bkchr commented Jul 13, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Jul 13, 2023 •
edited
Loading

@bkchr https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3179859 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 18-9c6a6bfa-658c-499f-b10a-e0eb94bbcbd0 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jul 13, 2023

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3179859 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3179859/artifacts/download.

@deepink-mas
Copy link
Contributor Author

Am I correct in understanding that this is blocked pending one more review or is there something I should do?

@sam0x17
Copy link
Contributor

sam0x17 commented Jul 20, 2023

Am I correct in understanding that this is blocked pending one more review or is there something I should do?

looks like the companions both have issues

@ggwpez
Copy link
Member

ggwpez commented Jul 25, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@ggwpez
Copy link
Member

ggwpez commented Jul 25, 2023

bot merge

@paritytech-processbot
Copy link

Error: "Check reviews" status is not passing for paritytech/polkadot#7465

@ggwpez
Copy link
Member

ggwpez commented Jul 25, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 96f8c97 into paritytech:master Jul 25, 2023
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

@andresilva andresilva Awaiting requested review from andresilva

@cheme cheme Awaiting requested review from cheme cheme is a code owner

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T2-API This PR/Issue is related to APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor HashFor and HashingFor
4 participants
@deepink-mas @bkchr @ggwpez @sam0x17