This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Nomination pools: disallow setting above global max commission #14496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2023 13:08
rossbulat
added
A3-in_progress
rossbulat
changed the title
liamaharon
approved these changes
Jul 3, 2023
Ank4n
approved these changes
Jul 3, 2023
|
bot merge |
rossbulat
added
A2-insubstantial
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…ytech#14496) * add CommissionExceedsGlobalMaximum * rename test * amend set_commission_max_works_with_error_tests * fmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces pools to not have a commission configured above
GlobalMaxCommission. The current code allows users to set a current commission and max commission aboveGlobalMaxCommission, without any error or warning when doing so.This PR explicitly fails the
set_commission_currentandset_max_commissioncalls if the provided commission is more thanGlobalMaxCommission.try_update_currentto not be aboveGlobalMaxCommission.try_update_maxto not be aboveGlobalMaxCommission.global_max_caps_max_commission_payouttest to account fortry_update_currentcheck.set_commission_max_works_with_error_testsfortry_update_maxcheck.