-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Convert all spelling to Google English #2138
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
It looks like @joepetrowski signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Ran a script across all the files and found these too. You should be able to cherry pick commits if you don't like any of the changes I introduced Still missing:
Due to downstream dependencies |
Councillor is still used more in US English. cancelled/canceled is basically a tie That's why I didn't do those three. Good catches on the others, I will handle rollback and update. |
My search for colour comes up empty, where do you see it? Behaviour I mentioned in my comment, will need to update libp2p.
|
Indeed. Some of those changes will need rolling back. We use:
I would basically go with the most common spelling on google for everything. "Google English". |
Otherwise, it looks good. |
@joepetrowski you can find Again, these are part of an external crate, so not much we can do, but just an FYI |
@@ -81,19 +81,19 @@ pub trait ChainApi<Number, Hash, Header, SignedBlock> { | |||
|
|||
/// New head subscription | |||
#[pubsub( | |||
subscription = "chain_finalisedHead", | |||
subscription = "chain_finalizedHead", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, we don't support aliases for subscription names, so this has to use the new name despite being subscribed via alias.
* all the ise * forgot a misspelling * a few more replacements * bump impl * rollback and fixes * bump impl again * Add aliases for RPC * Update on_demand.rs
Fixes #1768
The only remaining thing to change is a crate in libp2p called
behaviour
.