Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Database & keyring generation for benchmarks optimised #4945

Merged
merged 7 commits into from
Feb 17, 2020

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Feb 16, 2020

  • speeds up benchmarking dramatically (since keyring generation no longer done on every iteration)
  • allows to reuse seed databases (just clone, and you get a copy with brand new directory)

@NikVolf NikVolf added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Feb 16, 2020
bin/node/testing/benches/import.rs Outdated Show resolved Hide resolved
bin/node/testing/benches/import.rs Outdated Show resolved Hide resolved
bin/node/testing/benches/import.rs Outdated Show resolved Hide resolved
bin/node/testing/benches/import.rs Outdated Show resolved Hide resolved
bin/node/testing/benches/import.rs Outdated Show resolved Hide resolved
bin/node/testing/benches/import.rs Show resolved Hide resolved
@bkchr bkchr added the B0-silent Changes should not be mentioned in any release notes label Feb 17, 2020
NikVolf and others added 6 commits February 17, 2020 12:46
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
…e into nv-bench-db-organize

# Conflicts:
#	bin/node/testing/benches/import.rs
@NikVolf NikVolf merged commit d802fe2 into master Feb 17, 2020
@NikVolf NikVolf deleted the nv-bench-db-organize branch February 17, 2020 11:26
General-Beck pushed a commit to General-Beck/substrate that referenced this pull request Feb 18, 2020
* reorganize and optimize

* Update bin/node/testing/benches/import.rs

Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>

* Update bin/node/testing/benches/import.rs

Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>

* Update bin/node/testing/benches/import.rs

Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>

* review suggestions

* fix build

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
seunlanlege added a commit to paritytech/polkadot that referenced this pull request May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants