Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

New database trait #5549

Merged
merged 27 commits into from
Apr 15, 2020
Merged

New database trait #5549

merged 27 commits into from
Apr 15, 2020

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Apr 6, 2020 •
edited by arkpar
Loading

Polkadot companion PR: paritytech/polkadot#996

@gavofyork gavofyork requested a review from arkpar April 6, 2020 20:48
@gavofyork gavofyork added the A0-please_review Pull request needs code review. label Apr 6, 2020
@gavofyork gavofyork requested a review from cecton as a code owner April 7, 2020 15:20
@arkpar arkpar added the A1-onice label Apr 7, 2020
cecton
cecton suggested changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@cecton cecton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewing the CLI parts. There are a few issues but I proposed a fix for all of them

client/cli/src/config.rs Outdated Show resolved Hide resolved
client/cli/src/commands/mod.rs Show resolved Hide resolved
client/cli/src/config.rs Outdated Show resolved Hide resolved
client/cli/src/params/shared_params.rs Outdated Show resolved Hide resolved
client/cli/src/params/shared_params.rs Outdated Show resolved Hide resolved
@gavofyork gavofyork added A8-mergeoncegreen and removed A0-please_review Pull request needs code review. labels Apr 14, 2020
@arkpar arkpar removed the A1-onice label Apr 14, 2020
@arkpar arkpar mentioned this pull request Apr 14, 2020
Merged
arkpar
arkpar reviewed Apr 14, 2020
View reviewed changes
Copy link
Member

@arkpar arkpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the ways leaves are encoded in the DB. It is my understanding that the database upgrade is not really required though, as finality can progress anyway and leaves are overwritten after a few blocks are imported.

@gnunicorn gnunicorn requested a review from cecton April 14, 2020 14:34
@arkpar arkpar merged commit 88248c0 into master Apr 15, 2020
@arkpar arkpar deleted the gav-db-trait branch April 15, 2020 12:38
@tomaka
Copy link
Contributor

tomaka commented Apr 15, 2020 •
edited
Loading

I think master is now broken because we depend on a git repo that depends on this branch:

This also temporarily makes Substrate un-publish-able on crates.io

@davxy davxy mentioned this pull request Jul 23, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arkpar arkpar arkpar left review comments

@NikVolf NikVolf NikVolf left review comments

@pepyakin pepyakin pepyakin left review comments

@andresilva andresilva Awaiting requested review from andresilva

@Demi-Marie Demi-Marie Awaiting requested review from Demi-Marie

@kianenigma kianenigma Awaiting requested review from kianenigma

@gui1117 gui1117 Awaiting requested review from gui1117

@cecton cecton Awaiting requested review from cecton

Assignees

@cecton cecton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gavofyork @tomaka @pepyakin @cecton @NikVolf @arkpar @gnunicorn @paritytech-ci