Fix nits in rpc error display.

client/rpc-api/src/author/error.rs

@@ -114,10 +114,13 @@ impl From<Error> for rpc::Error {
 				message: format!("Verification Error: {}", e).into(),
 				data: Some(format!("{:?}", e).into()),
 			},
-			Error::Pool(PoolError::InvalidTransaction(e)) => rpc::Error {
-				code: rpc::ErrorCode::ServerError(POOL_INVALID_TX),
-				message: "Invalid Transaction".into(),
-				data: serde_json::to_value(e).ok(),
+			Error::Pool(PoolError::InvalidTransaction(e)) => {
+				let msg: &str = e.into();
+				rpc::Error {
+					code: rpc::ErrorCode::ServerError(POOL_INVALID_TX),
+					message: format!("Invalid Transaction: {}", msg).into(),
+					data: serde_json::to_value(e).ok(),
+				}
 			},
 			Error::Pool(PoolError::UnknownTransaction(e)) => rpc::Error {
 				code: rpc::ErrorCode::ServerError(POOL_UNKNOWN_VALIDITY),

client/transaction-pool/src/api.rs

@@ -105,7 +105,7 @@ where
 				#[allow(deprecated)] // old validate_transaction
 				runtime_api.validate_transaction_before_version_2(&at, uxt)
 			};
-			let res = res.map_err(|e| Error::RuntimeApi(format!("{:?}", e)));
+			let res = res.map_err(|e| Error::RuntimeApi(format!("{}", e)));
 			if let Err(e) = tx.send(res) {
 				log::warn!("Unable to send a validate transaction result: {:?}", e);
 			}

primitives/api/src/lib.rs

@@ -344,7 +344,7 @@ pub trait ConstructRuntimeApi<Block: BlockT, C: CallApiAt<Block>> {
 #[cfg(feature = "std")]
 pub trait ApiErrorExt {
 	/// Error type used by the runtime apis.
-	type Error: std::fmt::Debug + From<String>;
+	type Error: std::fmt::Debug + std::fmt::Display + From<String>;
 }
 
 /// Extends the runtime api implementation with some common functionality.
@@ -453,7 +453,7 @@ pub struct CallApiAtParams<'a, Block: BlockT, C, NC, Backend: StateBackend<HashF
 #[cfg(feature = "std")]
 pub trait CallApiAt<Block: BlockT> {
 	/// Error type used by the implementation.
-	type Error: std::fmt::Debug + From<String>;
+	type Error: std::fmt::Debug + std::fmt::Display + From<String>;
 
 	/// The state backend that is used to store the block states.
 	type StateBackend: StateBackend<HashFor<Block>>;

primitives/runtime/src/transaction_validity.rs

@@ -104,7 +104,7 @@ impl From<InvalidTransaction> for &'static str {
 			InvalidTransaction::BadMandatory =>
 				"A call was labelled as mandatory, but resulted in an Error.",
 			InvalidTransaction::MandatoryDispatch =>
-				"Tranaction dispatch is mandatory; transactions may not have mandatory dispatches.",
+				"Transaction dispatch is mandatory; transactions may not have mandatory dispatches.",
 			InvalidTransaction::Custom(_) => "InvalidTransaction custom error",
 		}
 	}