This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Extract frame_system SignedExtensions into separate files. #6474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-please_review
shawntabrizi
approved these changes
Jun 22, 2020
|
@shawntabrizi tests moved as well. |
bkchr
approved these changes
Jun 23, 2020
|
|
||
| /// Check for transaction mortality. | ||
| #[derive(Encode, Decode, Clone, Eq, PartialEq)] | ||
| pub struct CheckEra<T: Trait + Send + Sync>(Era, sp_std::marker::PhantomData<T>); |
There was a problem hiding this comment.
If we move this, can we may directly rename this?
And call it CheckMortality to make it more obvious what this is doing? I first always think that this checks the era.
| transaction_validity::{ | ||
| ValidTransaction, TransactionValidityError, InvalidTransaction, TransactionValidity, | ||
| }, | ||
|
|
|
This is fine - but let's not rush this through to the networks since it needs an API and extension rollout (with approvals). The signed extensions are used in there to make sense of the payload. |
|
CC @jacogr the |
tomusdrw
added
A8-mergeoncegreen
and removed
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
SignedExtensionsofframe_systemused to be placed in one fileframe/system/src/lib.rstogether with the module implementation and the tests.The file became rather large over time and the code & tests mixed up.
The PR moves each extension to it's own module under
extensionsdirectory and moves corresponding tests there as well. The test initialisation code is extracted tomock.rsfile, similar to how otherpalletsare structured.I didn't change any logic, nor did it change any APIs (extensions are re-exported), it only introduced a bunch of changes necessary to make the code work with the new structure (
pub(crate), etc).Done because I want to change how weights are parametrized and realised that I'd need to add a bunch of new lines to this enormous file, so rather decided to split it first.
Polkadot Companion: paritytech/polkadot#1306