This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove seals dependency on pallet_transaction_payment * Add weight as an argument to ext_gas_price
athei
added
A0-please_review
Pull request needs code review.
B3-apinoteworthy
C1-low
PR touches the given topic and has a low impact on builders.
labels
Jun 23, 2020
It looks like @athei signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
pepyakin
reviewed
Jun 23, 2020
Robbepop
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on a high-level
Eager to implement on ink! side soon.
niklasad1
reviewed
Jun 24, 2020
pepyakin
approved these changes
Jun 24, 2020
athei
added
A8-mergeoncegreen
and removed
A0-please_review
Pull request needs code review.
A7-needspolkadotpr
labels
Jun 24, 2020
bot merge |
Trying merge. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subset of: #6355
Overview
This PR changes the signature of
ext_gas_price
fromto
In addition to that we remove the dependency of seal on
pallet_transaction_payment
by adding those two elements to theTrait
:Motivation
There is no longer something like gas. We merely keep the term around for historical reasons. Costs are measured in weight. Currently, we provide gas price as the costs for one weight. Calculating the costs for a single weight is subject to rounding errors because the costs for one weight can be below one. In addition to that a fixed point adjustment is applied to the fee. Both of that makes calculating the costs for one weight very brittle. Contracts should therefore pass in higher amounts of gas to get a useful result.