This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove the legacy requests-answering protocols #6709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A1-onice
B0-silent
|
Update: it turns out that we still receive some requests, albeit few and on isolated nodes. I need to investigate first. |
twittner
approved these changes
Jul 29, 2020
|
We still receive block requests on the legacy substream, therefore I've changed the PR remove everything but the block requests. |
tomaka
added
A0-please_review
|
Needs resolving. |
|
bot merge |
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
|
bot rebase |
|
Rebasing. |
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes removing support for the block requests, finality requests, and light client requests protocols from
protocol.rs.All these protocols are already handled by other pieces of code elsewhere.
I'm marking this as
onicebecause I first would like to confirm with #6698 that we don't receive such requests anymore. At the moment it seems to be the case on my personal node, as this metric stays at 0, but I'd like to see it deployed on nodes that get more traffic.