This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add a LightSyncState
field to the chain spec
#6894
Merged
Merged
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
488d0a9
Reset code, almost ready for PR
expenses ddc7e3e
Merge remote-tracking branch 'origin/master' into ashley-chain-spec
expenses 15dcb28
Improved build_hardcoded_spec
expenses ecb2f56
Fix line widths
expenses 837c5f7
Fix tests
expenses 42d88d5
Fix sc-service-test
expenses 4288dc4
Suggestions from code review
expenses 44ff9f9
Rename to LightSyncState
expenses a6b5491
It's not syncing :^(
expenses c67d005
t Merge remote-tracking branch 'origin/master' into ashley-chain-spec…
expenses 346b711
It syncs!
expenses 6447b85
Remove rpc call
expenses 1adad2e
Convert spaces to tabs
expenses 9372667
Moved sc-service things to export_sync_state.rs
expenses db2da96
Fix tests
expenses b530147
Wait for syncing with network_status_sinks
expenses 004a8a4
Remove sc-network from node-template
expenses ea62d80
Apply suggestions from code review
expenses 9b558eb
Various changes, split the flag up into 2 pieces to make testing easier.
expenses fd1d2b1
Update client/cli/src/commands/build_spec_cmd.rs
expenses 57cbb15
Merge remote-tracking branch 'origin/master' into ashley-chain-spec
expenses fa51717
Revert a lot of changes
expenses 285c5af
Merge remote-tracking branch 'origin/master' into ashley-chain-spec
expenses File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
// Copyright 2020 Parity Technologies (UK) Ltd. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if I should move the contents of this file or not. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it is fine for now |
||
// This file is part of Substrate. | ||
|
||
// Substrate is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Substrate is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Substrate. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
use sp_runtime::traits::{Block as BlockT, NumberFor, Saturating, One}; | ||
use sp_blockchain::HeaderBackend; | ||
use crate::{TFullBackend, TLightBackend}; | ||
use std::sync::Arc; | ||
use sp_runtime::generic::BlockId; | ||
|
||
/// An error for if this function is being called on a full node. | ||
pub const CHT_ROOT_ERROR: &str = | ||
"Backend doesn't store CHT roots. Make sure you're calling this on a light client."; | ||
|
||
/// Something that might allow access to a `ChtRootStorage`. | ||
pub trait MaybeChtRootStorageProvider<Block> { | ||
/// Potentially get a reference to a `ChtRootStorage`. | ||
fn cht_root_storage(&self) -> Option<&dyn sc_client_api::light::ChtRootStorage<Block>>; | ||
} | ||
|
||
impl<Block: BlockT> MaybeChtRootStorageProvider<Block> for TFullBackend<Block> { | ||
fn cht_root_storage(&self) -> Option<&dyn sc_client_api::light::ChtRootStorage<Block>> { | ||
None | ||
} | ||
} | ||
|
||
impl<Block: BlockT> MaybeChtRootStorageProvider<Block> for TLightBackend<Block> { | ||
fn cht_root_storage(&self) -> Option<&dyn sc_client_api::light::ChtRootStorage<Block>> { | ||
Some(self.blockchain().storage()) | ||
} | ||
} | ||
|
||
/// Build a `LightSyncState` from the CHT roots stored in a backend. | ||
pub fn build_light_sync_state<TBl, TCl, TBackend>( | ||
client: Arc<TCl>, | ||
backend: Arc<TBackend>, | ||
) -> Result<sc_chain_spec::LightSyncState<TBl>, sp_blockchain::Error> | ||
where | ||
TBl: BlockT, | ||
TCl: HeaderBackend<TBl>, | ||
TBackend: MaybeChtRootStorageProvider<TBl>, | ||
{ | ||
let storage = backend.cht_root_storage().ok_or(CHT_ROOT_ERROR)?; | ||
|
||
let finalized_hash = client.info().finalized_hash; | ||
let finalized_number = client.info().finalized_number; | ||
|
||
use sc_client_api::cht; | ||
|
||
let mut chts = Vec::new(); | ||
|
||
// We can't fetch a CHT root later than `finalized_number - 2 * cht_size`. | ||
let cht_size_x_2 = cht::size::<NumberFor::<TBl>>() * NumberFor::<TBl>::from(2); | ||
|
||
let mut number = NumberFor::<TBl>::one(); | ||
|
||
while number <= finalized_number.saturating_sub(cht_size_x_2) { | ||
match storage.header_cht_root(cht::size(), number)? { | ||
Some(cht_root) => chts.push(cht_root), | ||
None => log::error!("No CHT found for block {}", number), | ||
} | ||
|
||
number += cht::size(); | ||
} | ||
|
||
Ok(sc_chain_spec::LightSyncState { | ||
header: client.header(BlockId::Hash(finalized_hash))?.unwrap(), | ||
chts, | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that
StorageData
is the best way to serialize these, but there could be a better alternative.