Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix weight for inner call with new origin #7196

Merged
2 commits merged into from
Oct 1, 2020
Merged

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Sep 24, 2020

inner call with different origin expect their origin accountdata to be already read and write by transaction nonce update. Thus we have to take this into account when it is actually not the case

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Sep 24, 2020
@gui1117 gui1117 added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Sep 24, 2020
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, but will be an overestimation since not all extrinsics may actually modify the user's account.

I wonder if there is a better long term solution that would lead to more accurate measurements.

@gui1117
Copy link
Contributor Author

gui1117 commented Sep 24, 2020

I guess we also need update the weight files in runtime, and maybe also default ones ?
Also for polkadot should modify weight files as a companion or only when releasing new runtime ?

I would be find just updating weight on new release for both substrate and polkadot, but updating node-runtime weight would allow to see how weights evolve.

@gui1117
Copy link
Contributor Author

gui1117 commented Oct 1, 2020

bot merge

@ghost
Copy link

ghost commented Oct 1, 2020

Trying merge.

@ghost ghost merged commit f8265a5 into master Oct 1, 2020
@ghost ghost deleted the gui-fix-inner-call-weight branch October 1, 2020 08:24
liuchengxu pushed a commit to liuchengxu/substrate that referenced this pull request Oct 5, 2020
* fix weight for inner call with new origin

* fix
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants