This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use storage::exists host function instead of ::get.
#7445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-please_review
bkchr
removed
the
D5-nicetohaveaudit ⚠️
bkchr
approved these changes
Oct 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that currently the
unhashedstorage does not check existence in the most efficient way.I suspect that due to old-clients compatibility we've decided to initially implement
existsusingsp_io::storage::read, but it obviously is sub-optimal, cause reads the entire value under the key, luckily transfers no bytes over to the WASM side, but merely check if it's notNone.The PR changes the method implementation to use
sp_io::storage::existsinstead, which is generally more optimized.