This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make pallets use construct_runtime #7950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 tasks
kianenigma
reviewed
Jan 21, 2021
frame/system/src/lib.rs
Outdated
|
|
||
|
|
||
| /// An unchecked extrinsic type to be used in test. | ||
| pub type MockUncheckedExtrinsic<T, Signature = (), Extra = ()> = generic::UncheckedExtrinsic< |
There was a problem hiding this comment.
better to make these std only?
There was a problem hiding this comment.
^^^ + put in some extra file testing.rs? Or something like that?
There was a problem hiding this comment.
Yes I moved into mocking.rs and made it std only
kianenigma
approved these changes
Jan 21, 2021
bkchr
reviewed
Jan 21, 2021
frame/system/src/lib.rs
Outdated
|
|
||
|
|
||
| /// An unchecked extrinsic type to be used in test. | ||
| pub type MockUncheckedExtrinsic<T, Signature = (), Extra = ()> = generic::UncheckedExtrinsic< |
There was a problem hiding this comment.
^^^ + put in some extra file testing.rs? Or something like that?
dvdplm
reviewed
Jan 22, 2021
dvdplm
reviewed
Jan 22, 2021
dvdplm
reviewed
Jan 22, 2021
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
gui1117
added
A3-in_progress
gui1117
added
A0-please_review
…o-construct_runtime
ascjones
reviewed
Jan 22, 2021
|
bot merge |
|
Waiting for commit status. |
|
Merge failed: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7949
This PR introduce a few types, and make pallet-assets use construct_runtime.