This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Storage chains: serve transactions over IPFS/bitswap #7963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-please_review
|
@tomaka please review or reassign |
tomaka
approved these changes
Jan 27, 2021
|
I've tested this against js-ipfs. |
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
cheme
reviewed
Jan 29, 2021
| @@ -95,6 +95,17 @@ pub trait BlockBackend<Block: BlockT> { | |||
|
|
|||
| /// Get block hash by number. | |||
| fn block_hash(&self, number: NumberFor<Block>) -> sp_blockchain::Result<Option<Block::Hash>>; | |||
|
|
|||
| /// Get single extrinsic by hash. | |||
There was a problem hiding this comment.
Should we name the method transaction.
Also wondering if we should comment the fact that in some case do not have result depending on node configuration (in previous pr column 'TRANSACTION' was only optionally use).
client/api/src/in_mem.rs
Outdated
| &self, | ||
| _hash: &Block::Hash, | ||
| ) -> sp_blockchain::Result<Option<<Block as BlockT>::Extrinsic>> { | ||
| unimplemented!() |
There was a problem hiding this comment.
will it be implemented later, if not maybe add a parameter message saying that it is unsupported.
cheme
approved these changes
Feb 2, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7962
Initially I've tried implementing this as request-response protocol, but found out it is not suitable due to paritytech/polkadot-sdk#542.
polkadot companion: paritytech/polkadot#2315