This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix some problems with prove_warp_sync
#8037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expenses
added
A0-please_review
tomaka
approved these changes
Feb 3, 2021
cheme
reviewed
Feb 3, 2021
| @@ -289,7 +289,7 @@ pub fn prove_warp_sync<Block: BlockT, B: BlockchainBackend<Block>>( | |||
|
|
|||
| let mut index = *header.number(); | |||
| while index <= end_number { | |||
| if max_fragment_limit.map(|limit| result.len() <= limit).unwrap_or(false) { | |||
| if max_fragment_limit.map(|limit| result.len() >= limit).unwrap_or(false) { | |||
| if result.last().as_ref().map(|head| head.header.number()) != Some(&end_number) { | ||
| let at_limit = max_fragment_limit.map(|limit| result.len() >= limit).unwrap_or(false); | ||
|
|
||
| if !at_limit && result.last().as_ref().map(|head| head.header.number()) != Some(&end_number) { |
There was a problem hiding this comment.
👍 when at_limit we probably had twice the fragment
Actually realize this condition was not really simple to read, the point was just add the last finalized block if not already added, so I added a code suggestion bellow.
Co-authored-by: cheme <emericchevalier.pro@gmail.com>
…tytech/substrate into ashley-fix-prove-warp-sync-problems
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.