This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
sc-network: switch on default features for libp2p on non-wasm-builds #8088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnunicorn
added
A2-insubstantial
tomaka
approved these changes
Feb 9, 2021
romanb
approved these changes
Feb 9, 2021
mxinden
approved these changes
Feb 9, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently
sc-networkdoesn't build if separated from the rest of workspace (see libp2p/rust-libp2p#1952). This fix flips the dependency switch around: activates the libp2p default features and excludes some for wasm-builds.