Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix warning in rustdoc job #8159

Merged
merged 4 commits into from
Feb 19, 2021
Merged

Fix warning in rustdoc job #8159

merged 4 commits into from
Feb 19, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Feb 18, 2021

No description provided.

@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 18, 2021
@bkchr
Copy link
Member Author

bkchr commented Feb 19, 2021

@TriplEight I removed the rust-doc job until upstream is fixed: rust-lang/rust#82284

TriplEight
TriplEight suggested changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@TriplEight TriplEight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just allow_failure: true
with FIXME and a link to a bug.

@TriplEight TriplEight self-requested a review February 19, 2021 12:06
@TriplEight TriplEight merged commit 1c842c4 into master Feb 19, 2021
@TriplEight TriplEight deleted the bkchr-fix-warning-rustdocs branch February 19, 2021 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kianenigma kianenigma kianenigma approved these changes

@TriplEight TriplEight TriplEight approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkchr @kianenigma @TriplEight