This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Replace 'Module' with 'Pallet' in construct_runtime macro #8372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
A5-grumble
C1-low
|
This will needs a companion, and there is remainings usage of deprecated Modle type alias, you can see in the CI continuous-integration/gitlab-test-linux-stable We should deprecate AllModule and AllModuleWithSystem instead of removing them IMHO. Then the only breaking change of this PR is the construct_runtime macro which requires Pallet instead of Module. |
gui1117
added
A0-please_review
gui1117
approved these changes
Mar 16, 2021
gui1117
added
the
D5-nicetohaveaudit ⚠️
shawntabrizi
approved these changes
Mar 18, 2021
|
gonna be honest, did not look at every line of code, but scrolled through quickly |
shawntabrizi
added
D3-trivial 🧸
|
bot merge |
|
Trying merge. |
ghost
merged commit 
|
I think a lot of thing need to be changed.
Otherwise, this make people feel so confusing. |
|
I agree |
Well. Can you assign that to me? : ) |
|
Yes a PR is welcome, I don't think ppl are working on it, you can ping me on the PR if you open it |
AurevoirXavier
added a commit
to darwinia-network/substrate
that referenced
this pull request
Mar 29, 2021
HCastano
added a commit
to paritytech/parity-bridges-common
that referenced
this pull request
Apr 6, 2021
Related Substrate PR: paritytech/substrate#8372
HCastano
added a commit
to paritytech/parity-bridges-common
that referenced
this pull request
Apr 7, 2021
* Bump Substrate * Change usage of "Module" to "Pallet" Related Substrate PR: paritytech/substrate#8372 * Add `OnSetCode` config param Related Substrate PR: paritytech/substrate#8496 * Update Aura Slot duration time type Related Substrate PR: paritytech/substrate#8386 * Add `OnSetCode` to mock runtimes * Add support for multiple justifications Related Substrate PR: paritytech/substrate#7640 * Use updated justification type in more places * Make GenesisConfig type non-optional Related Substrate PR: paritytech/substrate#8275 * Update service to use updated telemetry Related Substrate PR: paritytech/substrate#8143 * Appease Clippy
ghost
pushed a commit
that referenced
this pull request
Apr 9, 2021
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
…#8372) * Use 'Pallet' struct in construct_runtime. * Fix genesis and metadata macro. * Fix 'Pallet' type alias. * Replace 'Module' with 'Pallet' for all construct_runtime use cases. * Replace more deprecated 'Module' struct. * Bring back AllModules and AllPalletsWithSystem type, but deprecate them. * Replace deprecated 'Module' struct from merge master. * Minor fix. * Fix UI tests. * Revert UI override in derive_no_bound. * Fix more deprecated 'Module' use from master branch. * Fix more deprecated 'Module' use from master branch.
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
* `ModuleId` to `PalletId` - part of paritytech#8372 * fix doc * move `PalletId` to `frame-support` * fix compile * fix tests * `ModuleId` to `PalletId` * subcommand `moduleid` to `palletid`
jordy25519
pushed a commit
to cennznet/substrate
that referenced
this pull request
Sep 20, 2021
* `ModuleId` to `PalletId` - part of paritytech#8372 * fix doc * move `PalletId` to `frame-support` * fix compile * fix tests * `ModuleId` to `PalletId` * subcommand `moduleid` to `palletid`
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8287 .
Changes in this PR:
ModulewithPalletas pallet keyword inconstruct_runtimemacro.modulerelated types/fns inconstruct_runtimeimpl.Pallettype alias indecl_module, to make it compatible with newPalletkeyword inconstruct_runtime.construct_runtimeusage in mocks, runtimes.Moduletype alias in pallet macro. Additionally replace all deprecated usage.cc @shawntabrizi @thiolliere
Polkadot companion: paritytech/polkadot#2629