Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

FRAME: Assets Freezer pallet #8476

Closed
wants to merge 29 commits into from
Closed

FRAME: Assets Freezer pallet #8476

wants to merge 29 commits into from

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Mar 28, 2021

Probably pretty stale now, but...

Polkadot companion: paritytech/polkadot#3131

TODO:

  • Rename AssetsFreezer to AssetsHolder.
  • Tweak AssetsHolder to implement the new fungibles::hold::* API.
  • Introduce new AssetsFreezer which implements fungibles::freeze::* API.
  • Tests.

@gavofyork gavofyork added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Mar 28, 2021
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 28, 2021
@apopiak apopiak added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Mar 29, 2021
@gavofyork gavofyork added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 30, 2021
@xlc
Copy link
Contributor

xlc commented Apr 19, 2021

Holds should be named like #7778

Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riusricardo what's the status quo here?

@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 7, 2021
@olanod
Copy link
Contributor

olanod commented Jul 12, 2021

No love for this one? is it blocked in some big way? just here to tell stale bot 🤖 that this is important and if there's anything us the simple mortals can do to help we'll be glad to.

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 12, 2021
@zauddelig
Copy link

what is blocking this issue?

@stale
Copy link

stale bot commented Aug 18, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Aug 18, 2021
@stale stale bot closed this Sep 1, 2021
@gui1117
Copy link
Contributor

gui1117 commented Sep 6, 2021

AFAIK it is still relevant, it is just less priority than the other stuff

@gui1117 gui1117 reopened this Sep 6, 2021
@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Sep 6, 2021
@zauddelig
Copy link

@thiolliere If I wanted to takeover what would be required to merge it?

@gui1117
Copy link
Contributor

gui1117 commented Sep 6, 2021

@thiolliere If I wanted to takeover what would be required to merge it?

When the PR was opened it only needed to be reviewed, now we also need to merge master. But it only makes sense to keep it up to date if people are available for reviewing it.

@zauddelig
Copy link

zauddelig commented Sep 6, 2021 via email

@stale
Copy link

stale bot commented Oct 6, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Oct 6, 2021
@stale stale bot closed this Oct 20, 2021
@gavofyork gavofyork reopened this Mar 6, 2023
@gavofyork gavofyork changed the title Assets Freezer pallet FRAME: Assets Freezer pallet Mar 19, 2023
@stale
Copy link

stale bot commented Apr 18, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A3-stale A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants