Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update to libp2p 0.37 #8625

Merged
3 commits merged into from
Apr 18, 2021
Merged

Update to libp2p 0.37 #8625

3 commits merged into from
Apr 18, 2021

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Apr 15, 2021

The biggest PRs are:

None of the changes touch anything related to connections or existing protocols, so I don't think a burn-in is necessary.

polkadot companion: paritytech/polkadot#2894

@tomaka tomaka added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 15, 2021
@tomaka
Copy link
Contributor Author

tomaka commented Apr 16, 2021

This needs a Polkadot companion just to do a cargo update -p wasm-bindgen in Polkadot 🤦

@TriplEight
Copy link
Contributor

@tomaka I've updated the production image, but it did not get a 73' version of wasm-bindgen.
The reason is

# cargo install wasm-bindgen
    Updating crates.io index
  Downloaded wasm-bindgen v0.2.73
  Downloaded 1 crate (159.3 KB) in 0.65s
error: specified package `wasm-bindgen v0.2.73` has no binaries

Here's a test with a new image.

@tomaka
Copy link
Contributor Author

tomaka commented Apr 17, 2021

It's cargo install wasm-bindgen-cli, not just wasm-bindgen.
Normally the CI image already installs version 0.2.71, it just needs to be changed to 73.

@TriplEight
Copy link
Contributor

TriplEight commented Apr 17, 2021

@tomaka new image with wasm-bindgen-cli=0.2.73 is in production tag and your test has passed. Master for the image has passed everything but a browser test.

In order to fix master, this PR has to be merged.

@tomaka
Copy link
Contributor Author

tomaka commented Apr 18, 2021

bot merge

@ghost
Copy link

ghost commented Apr 18, 2021

Trying merge.

@ghost
Copy link

ghost commented Apr 18, 2021

Bot will approve on the behalf of @tomaka, since they are a team lead, in an attempt to reach the minimum approval count

@ghost ghost merged commit 4b9a6bb into paritytech:master Apr 18, 2021
@tomaka tomaka deleted the libp2p-0.37 branch April 18, 2021 08:04
kianenigma pushed a commit that referenced this pull request Jul 5, 2021
* Update to libp2p 0.37

* Line widths

* Fix tests
jordy25519 pushed a commit to cennznet/substrate that referenced this pull request Sep 17, 2021
* Update to libp2p 0.37

* Line widths

* Fix tests
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants