This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Authority-discovery no longer publishes non-global IP addresses #8643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
ordian
approved these changes
Apr 20, 2021
Co-authored-by: Andronik Ordian <write@reusable.software>
|
bot merge |
|
Error: #8643 is not mergeable |
|
@parity-processbot Why? |
|
bot merge |
|
Trying merge. |
|
Bot will approve on the behalf of @tomaka, since they are a team lead, in an attempt to reach the minimum approval count |
ghost
approved these changes
Apr 20, 2021
ghost
merged commit
|
🤷 |
|
cc @joao-paulo-parity ^^^ |
|
In that case it was Github saying the PR was not mergeable, not the bot's rules. I think we can clarify that error message by telling where it came from. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authority discover no longer publishes non-global IP addresses on the DHT, unless the user is running a local/dev chain or if
--discover-localis passed.polkadot companion: paritytech/polkadot#2908