This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Emit wasm sections only when compiling to wasm #8845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
added
A0-please_review
This was referenced May 18, 2021
bkchr
approved these changes
May 18, 2021
|
I can confirm this builds locally on my macOS machine. |
|
bot merge |
|
Trying merge. |
|
Bot will approve on the behalf of @pepyakin, since they are a team lead, in an attempt to reach the minimum approval count |
ghost
approved these changes
May 18, 2021
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up for #8688
This PR limits emitting the runtime version sections only to when the runtime is compiled to wasm.
Without this, a user can get: