Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Rename Burn to Slash in Assets #8878

Closed
wants to merge 6 commits into from
Closed

Rename Burn to Slash in Assets #8878

wants to merge 6 commits into from

Conversation

joepetrowski
Copy link
Contributor

@joepetrowski joepetrowski commented May 21, 2021

Renames burn to slash to update API for Statemint. Also removes duplicate Burned and Issued events.

@joepetrowski joepetrowski added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 21, 2021
@apopiak
Copy link
Contributor

apopiak commented May 21, 2021

Should we also adjust the event to Slashed?

@joepetrowski
Copy link
Contributor Author

Should we also adjust the event to Slashed?

I think it makes sense in the context of assets, but don't want to rename the helper functions (e.g. do_burn) as it creeps into the fungibles trait.

@Swader
Copy link
Contributor

Swader commented May 21, 2021

What is the rationale behind this change?

@apopiak
Copy link
Contributor

apopiak commented May 21, 2021

@gavofyork Can you give your reasoning?

@Swader
Copy link
Contributor

Swader commented May 28, 2021

Still interested in learning more about the reasoning here. To me, slash has very clear connotations of "owner of asset having promised to do something and failing to deliver on that promise, thereby getting slashed". To me at least, slash clearly communicates punishment. Burn on the other hand covers both self-inflicted ops and burns from an admin, with or without a previous commitment (e.g. tether is ordered to burn some amount in my account, but also I can burn some amount of USDT in my account on my own - in neither case did I have a commitment to the network the dishonoring of which would punish me through a slash).

@joepetrowski joepetrowski changed the title rename burn to slash Rename Burn to Slash in Assets May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants