Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Avoid running some test 2 times when unneeded #9124

Merged
2 commits merged into from
Jun 16, 2021
Merged

Avoid running some test 2 times when unneeded #9124

2 commits merged into from
Jun 16, 2021

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Jun 16, 2021

This PR makes CI execute only the pallet test with conditional-storage.

In case some other test takes some times this is more efficient. Otherwise we can simply ignore all UI test and execute all other test 2 times.

@gui1117 gui1117 requested a review from a team as a code owner June 16, 2021 10:25
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jun 16, 2021
@gui1117 gui1117 requested a review from TriplEight June 16, 2021 10:25
@gui1117 gui1117 added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 16, 2021
TriplEight
TriplEight approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@TriplEight TriplEight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's a good solution not to run the unnecessary tests twice.

@gui1117 gui1117 requested a review from KiChjang June 16, 2021 13:24
@gui1117
Copy link
Contributor Author

gui1117 commented Jun 16, 2021

bot merge

@ghost
Copy link

ghost commented Jun 16, 2021

Waiting for commit status.

@ghost ghost merged commit ede9bc1 into master Jun 16, 2021
@ghost ghost deleted the gui-avoid-executing-ui-test-2times branch June 16, 2021 16:19
ordian added a commit that referenced this pull request Jun 17, 2021
@ordian
Merge branch 'master' into rococo-experimental
fe658f6 
* master:
  double the allocator limit (#9102)
  Make it possible to override maximum payload of RPC (#9019)
  Aura: Skip initialize block & remove cache (#9132)
  Avoid running some test 2 times when unneeded (#9124)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TriplEight TriplEight TriplEight approved these changes

@bkchr bkchr bkchr approved these changes

@KiChjang KiChjang Awaiting requested review from KiChjang

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gui1117 @bkchr @TriplEight