Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix allocator waste assessment in docs #9167

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Fix allocator waste assessment in docs #9167

merged 3 commits into from
Jun 22, 2021

Conversation

tomusdrw
Copy link
Contributor

@tomusdrw tomusdrw added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Jun 22, 2021
@tomusdrw tomusdrw requested a review from gavofyork June 22, 2021 07:26
@tomusdrw tomusdrw changed the title Fix allocator comment. Fix allocator waste assesement in docs Jun 22, 2021
@tomusdrw tomusdrw added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Jun 22, 2021
kianenigma
kianenigma approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be interesting to add how 25% is deduced as well.

@apopiak apopiak changed the title Fix allocator waste assesement in docs Fix allocator waste assessment in docs Jun 22, 2021
@pepyakin pepyakin mentioned this pull request Jun 22, 2021
Merged
@bkchr bkchr merged commit 4ac2a53 into master Jun 22, 2021
@bkchr bkchr deleted the td-allocator-comment branch June 22, 2021 11:20
athei pushed a commit that referenced this pull request Jun 25, 2021
@tomusdrw @athei
Fix allocator waste assessment in docs (#9167)
9042075 
* Fix allocator comment.

* Add explanations where this comes from.

* Clarify absolute values.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apopiak apopiak apopiak approved these changes

@kianenigma kianenigma kianenigma approved these changes

@pepyakin pepyakin pepyakin approved these changes

@gavofyork gavofyork Awaiting requested review from gavofyork

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomusdrw @pepyakin @kianenigma @apopiak @bkchr