This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Migrate pallet-mmr to the new pallet attribute macro
#9181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
tomusdrw
approved these changes
Jul 8, 2021
tomusdrw
added
A0-please_review
|
@koushiro would you be so kind to prepare a polkadot companion PR (migrating the existing instance)? |
gui1117
reviewed
Jul 12, 2021
gui1117
approved these changes
Jul 12, 2021
|
@tomusdrw is it ok to merge once green ? or should I ping somebody about the rococo restart ? |
|
We were planning to do Rococo runtime upgrade/restart anyway, so IMHO good to merge. |
|
bot merge |
|
Trying merge. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7882
Migrate the
pallet-mmrto the new pallet attribute macrodiff mmr-before.json mmr-after.json (metadata of substrate/bin/node):
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the pallet must be careful about the name they used in
construct_runtime!. Hence theruntime-migrationlabel, which might not be needed depending on the configuration of the pallet.polkadot/kusama/westenddon't usepallet-mmrfor runtime, so no need for migration there.(However,
rococousedpallet-mmr, I'm not sure if need to migrate storage forrococo)/cc @shawntabrizi @thiolliere