Implement iter_keys function for all types of storage maps
#9238
Conversation
KiChjang
added
B3-apinoteworthy
C1-low
There was a problem hiding this comment.
Looks good. I'm not convinced that drain_keys and friends are really worth it; it seems like they're justified only if decoding the values takes non-trivial time. If you do choose to keep them, it would be good to test them, not just the iter_keys variants.
Still, the code overall looks good.
| prefix: Vec<u8>, | ||
| previous_key: Vec<u8>, | ||
| /// If true then value are removed while iterating | ||
| drain: bool, |
There was a problem hiding this comment.
This is a normal way of doing this?
There was a problem hiding this comment.
We do similar for PrefixIterator, that would allow use to create drain_keys easily if we want.
There was a problem hiding this comment.
I actually spend a few minutes trying to see if we can merge this with PrefixIterator, the impls are pretty similar, only the decoding closure is different.
There was a problem hiding this comment.
@kianenigma seems hard to have the output be only keys or also keys and values. (i.e. making an API that makes sense and works in both scenarios?)
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
Fixes #9118.