This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove impl_outer_ macros #9307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
A3-in_progress
github-actions
bot
added
A0-please_review
gui1117
commented
Jul 8, 2021
| ); | ||
|
|
||
| assert_eq!(Runtime::ensure_inherents_are_first(&block).err().unwrap(), 2); | ||
| } |
There was a problem hiding this comment.
note: those tests are in frame/support/test/tests/pallets.rs
| origin_without_generic::Origin | ||
| ); | ||
| assert_eq!(without_generic_variant.encode()[0], 1); | ||
| } |
There was a problem hiding this comment.
origin tests are in frame/support/test/tests/construct_runtime.rs
| #[test] | ||
| fn test_codec() { |
There was a problem hiding this comment.
codec test is in frame/support/test/tests/construct_runtime.rs
| fn get_module_names() { | ||
| let module_names = OuterCall::get_module_names(); | ||
| assert_eq!(["Test"], module_names); | ||
| } |
There was a problem hiding this comment.
those tests are in frame/support/test/tests/construct_runtime.rs
gui1117
added
A3-in_progress
gui1117
force-pushed
the
gui-remove-impl_outer
branch
from
1614d0d
to
a26531c
Compare
gui1117
commented
Jul 8, 2021
| #[doc(hidden)] | ||
| pub use crate::sp_runtime::transaction_validity::{ | ||
| TransactionValidity, UnknownTransaction, TransactionValidityError, TransactionSource, | ||
| }; |
There was a problem hiding this comment.
all those reexport were already hidden, some are used by construct_runtime, some are used by some pallet.
gui1117
added
A0-please_review
19 tasks
shawntabrizi
approved these changes
Jul 8, 2021
bkchr
approved these changes
Jul 8, 2021
|
farewell macro rules |
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those macro are no longer used, people should rather use construct_runtime, it is some code debt when implementing new functionality in substrate (e.g. metadata changes).