This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add methods to PrefixIterator to support iterating from a specific key #9313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
KiChjang
commented
Jul 9, 2021
gui1117
reviewed
Jul 12, 2021
kianenigma
reviewed
Jul 12, 2021
kianenigma
reviewed
Jul 12, 2021
There was a problem hiding this comment.
I feel like the PR is correct, but incomplete. I don't see any change in public interfaces like IterableStorageMap etc. My assumption was that there'd be a new fn iter_from() added to these traits, which would create an iterating type from KeyPrefixIterator or similar types.
gui1117
reviewed
Jul 13, 2021
gui1117
reviewed
Jul 15, 2021
kianenigma
reviewed
Jul 22, 2021
| fn drain_prefix(k1: impl EncodeLike<K1>) -> Self::PrefixIterator { | ||
| let mut iterator = Self::iter_prefix(k1); | ||
| iterator.drain = true; | ||
| iterator | ||
| } | ||
|
|
||
| fn iter() -> Self::Iterator { | ||
| Self::iter_from(G::prefix_hash()) |
There was a problem hiding this comment.
Wee bit strange here. iter_from is already reading let prefix = G::prefix_hash();, but we pass in G::prefix_hash() to it again. I'd make the starting_raw_key an Option.
There was a problem hiding this comment.
I guess we can just revert this and implement iter_from in terms of iter by calling set_previous_key on the resulting PrefixIterator.
kianenigma
reviewed
Jul 22, 2021
| @@ -144,10 +144,15 @@ impl< | |||
|
|
|||
| /// Enumerate all elements in the map. | |||
| fn iter() -> Self::Iterator { | |||
| Self::iter_from(G::prefix_hash()) | |||
kianenigma
approved these changes
Jul 22, 2021
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
19 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9213.
This adds methods that aid in paginating storage iterators. I imagine that this will be used heavily in storage migrations that span multiple blocks, or other sorts of consensus mechanisms that span multiple blocks and require interaction with storage.