Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Box variant for pallet calls #9398

Closed
wants to merge 1 commit into from
Closed

Box variant for pallet calls #9398

wants to merge 1 commit into from

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Jul 20, 2021

This way the size of the pallet calls are not "shared", some pallet can have very big calls while some other keep small ones, they don't all inherit the size of the biggest pallet call.

@gui1117 gui1117 added A0-please_review Pull request needs code review. B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jul 20, 2021
@gui1117
Copy link
Contributor Author

gui1117 commented Jul 20, 2021

the consequence are a slightly more expensive batch and batch_all similar to #9339
Needs #9343 to benchmark properly

@gui1117 gui1117 added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Jul 20, 2021
@gui1117
Copy link
Contributor Author

gui1117 commented Jul 20, 2021

Damn but that requires lot of change every time we match on the pallet call variant :-/

@gui1117
Copy link
Contributor Author

gui1117 commented Jul 20, 2021

for me best solution was still #9339

@gui1117 gui1117 closed this Jul 21, 2021
@gui1117 gui1117 deleted the gui-box-variant branch July 21, 2021 13:11
@louismerlin louismerlin removed the D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited label Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants