This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix staking rebond weight refund
#9508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
approved these changes
Aug 6, 2021
frame/staking/src/pallet/mod.rs
Outdated
| ) | ||
| .into()) | ||
|
|
||
| let removed_chunks = 1 + // account the case where last iterated chunk is not removed |
There was a problem hiding this comment.
better use safe arithmetic
There was a problem hiding this comment.
and FYI the dependency of this function on unlocking is super small (substrate weight: .saturating_add((35_000 as Weight).saturating_mul(l as Weight)), which is very small)
kianenigma
added
A0-please_review
gui1117
approved these changes
Aug 9, 2021
gui1117
reviewed
Aug 9, 2021
| let ledger = ledger.rebond(value); | ||
| // Last check: the new active amount of ledger must be more than ED. | ||
| ensure!(ledger.active >= T::Currency::minimum_balance(), Error::<T>::InsufficientBond); | ||
|
|
||
| Self::deposit_event(Event::<T>::Bonded(ledger.stash.clone(), value)); | ||
| Self::update_ledger(&controller, &ledger); | ||
| Ok(Some( | ||
| 35 * WEIGHT_PER_MICROS + | ||
| 50 * WEIGHT_PER_NANOS * (ledger.unlocking.len() as Weight) + |
There was a problem hiding this comment.
it seems the previous formula is wrong as it just look at the final unlocking len.
|
bot merge |
|
Trying merge. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the weight refund for pallet-staking's rebond. The rebond benchmark is variant over the number of unlocking chunks iterated over; so in this PR we calculate the max amount of "relocked" chunks and pass that too
WeightInfo::rebondto get the actual weight.