This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove Filter and use Contains instead #9514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
requested review from
andresilva,
athei and
kianenigma
as code owners
47 tasks
gavofyork
added
A0-please_review
pepyakin
approved these changes
Aug 7, 2021
kianenigma
reviewed
Aug 7, 2021
shawntabrizi
approved these changes
Aug 7, 2021
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
KiChjang
reviewed
Aug 7, 2021
KiChjang
approved these changes
Aug 7, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
liuchengxu
pushed a commit
to canyon-network/substrate
that referenced
this pull request
Aug 8, 2021
* Remove Filter and use Contains instead * Fixes * Formatting * Update docs/Upgrading-2.0-to-3.0.md Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Typo Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Expose BabeVerifier
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of paritytech/polkadot#2841
Companion: paritytech/polkadot#3591
FilterandContainsdo exactly the same thing, but are used in slightly different contexts. This just merges them, allowing some utilities written forContainsto be used whereFilterwas in use.Migration
Items within
frame_support::traits:Filtershould be replaced withContains.Filter::filter()should be replaced withContains::contains(). This includes derivative usage within the inheriting traitFilterStack.All<...>should be replaced withEverything(NOTE: The type agument should be dropped).AllowAllshould be replaced withEverythingDenyAllshould be replaced withNothing