This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Prepare UI tests for rust 1.55 #9637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
added
A0-please_review
gui1117
reviewed
Aug 27, 2021
primitives/npos-elections/solution-type/tests/ui/fail/wrong_page.stderr
Outdated
Show resolved
Hide resolved
gui1117
approved these changes
Aug 27, 2021
gilescope
approved these changes
Aug 28, 2021
rcny
approved these changes
Aug 30, 2021
|
@rcny you need to run the CI jobs of this pr with the new CI image. @TriplEight should be able to help you with this. |
|
I'm testing the same on the polkadot companion, then revert both commits, merge the new CI image and merge these both PRs. |
|
Pipelines are failing with new Rust versions. |
|
the failing message is the one of the failing job of this PR ? |
Nice. I will merge master after your pr is in master |
gui1117
approved these changes
Sep 14, 2021
|
@thiolliere could you merge master please. @TriplEight after that we should be finally ready to merge this |
|
it should be good now |
Merged
|
bot merge |
|
Trying merge. |
ghost
merged commit
This was referenced Sep 27, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9627
polkadot companion: paritytech/polkadot#3807